From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 087/142] t7006-pager.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:48 -0700 Message-ID: <1395768283-31135-88-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:13 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDh-0004n1-LO for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:02 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754995AbaCYR0k convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:26:40 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:49200 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932148AbaCYR02 (ORCPT ); Tue, 25 Mar 2014 13:26:28 -0400 Received: by mail-pb0-f42.google.com with SMTP id rr13so757402pbb.1 for ; Tue, 25 Mar 2014 10:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ueYWnfz2BV4S1aMQVMEhCh/hSTKqkqSre84QpPPTzmw=; b=J/e/+YADKbqcc8HHOPMFbcUEiumkE7A5FpQzqF8zGeTRziyeArjLcMcfJihfqxkgCR 44Xcw/haqimmgDhG40DcbdWwZtkvshFQMNRP+Lp+sLAH+eWFxIa9oitm/qnznVgzkifY b8VRr7uJ/QiNtr7DpssHcg6pNyfvgrdl7SvwD6Oqz4OUm8xiFadF1L9sXrGw6AjEpYl7 RvEaCyJxSf3xSBPMoU6LrgDVZQVdopl8NlAD9gw88ezKbMF+C8qjNQdAiJLn3o9UR4jo aBT40bhnhlVaIlHOo3NUTE4sOtpKJYYNiqNTZiH2waCHHBkvaln2jATy7ccj1zaHd49/ KSdQ== X-Received: by 10.66.218.234 with SMTP id pj10mr11090117pac.156.1395768388197; Tue, 25 Mar 2014 10:26:28 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.26 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:27 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t7006-pager.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh index b9365b4..7576fa9 100755 --- a/t/t7006-pager.sh +++ b/t/t7006-pager.sh @@ -436,7 +436,7 @@ test_expect_success TTY 'command-specific pager wor= ks for external commands' ' echo "foo:initial" >expect && >actual && test_config pager.external "sed s/^/foo:/ >actual" && - test_terminal git --exec-path=3D"`pwd`" external log --format=3D%s -1= && + test_terminal git --exec-path=3D"$(pwd)" external log --format=3D%s -= 1 && test_cmp expect actual ' =20 --=20 1.7.10.4