From: "Michael S. Tsirkin" <mst@redhat.com>
To: git@vger.kernel.org
Cc: jrnieder@gmail.com, peff@peff.net, gitster@pobox.com
Subject: [PATCH 3/3] patch-id-test: test new --stable and --unstable flags
Date: Thu, 27 Mar 2014 11:25:22 +0200 [thread overview]
Message-ID: <1395912239-29663-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1395912239-29663-1-git-send-email-mst@redhat.com>
Verify that patch ID is now stable against hunk reordering.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
t/t4204-patch-id.sh | 68 +++++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 63 insertions(+), 5 deletions(-)
diff --git a/t/t4204-patch-id.sh b/t/t4204-patch-id.sh
index d2c930d..75f77ef 100755
--- a/t/t4204-patch-id.sh
+++ b/t/t4204-patch-id.sh
@@ -5,12 +5,27 @@ test_description='git patch-id'
. ./test-lib.sh
test_expect_success 'setup' '
- test_commit initial foo a &&
- test_commit first foo b &&
+ test_commit initial-foo foo a &&
+ test_commit initial-bar bar a &&
+ echo b > foo &&
+ echo b > bar &&
+ git commit -a -m first &&
git checkout -b same HEAD^ &&
- test_commit same-msg foo b &&
+ echo b > foo &&
+ echo b > bar &&
+ git commit -a -m same-msg &&
git checkout -b notsame HEAD^ &&
- test_commit notsame-msg foo c
+ echo c > foo &&
+ echo c > bar &&
+ git commit -a -m notsame-msg &&
+ cat > bar-then-foo <<EOF
+bar
+foo
+EOF
+ cat > foo-then-bar <<EOF
+foo
+bar
+EOF
'
test_expect_success 'patch-id output is well-formed' '
@@ -23,11 +38,33 @@ calc_patch_id () {
sed "s# .*##" > patch-id_"$1"
}
+calc_patch_id_unstable () {
+ git patch-id --unstable |
+ sed "s# .*##" > patch-id_"$1"
+}
+
+calc_patch_id_stable () {
+ git patch-id --stable |
+ sed "s# .*##" > patch-id_"$1"
+}
+
+
get_patch_id () {
- git log -p -1 "$1" | git patch-id |
+ git log -p -1 "$1" -O bar-then-foo -- | git patch-id |
+ sed "s# .*##" > patch-id_"$1"
+}
+
+get_patch_id_stable () {
+ git log -p -1 "$1" -O bar-then-foo | git patch-id --stable |
+ sed "s# .*##" > patch-id_"$1"
+}
+
+get_patch_id_unstable () {
+ git log -p -1 "$1" -O bar-then-foo | git patch-id --unstable |
sed "s# .*##" > patch-id_"$1"
}
+
test_expect_success 'patch-id detects equality' '
get_patch_id master &&
get_patch_id same &&
@@ -56,6 +93,27 @@ test_expect_success 'whitespace is irrelevant in footer' '
test_cmp patch-id_master patch-id_same
'
+test_expect_success 'file order is irrelevant by default' '
+ get_patch_id master &&
+ git checkout same &&
+ git format-patch -1 --stdout -O foo-then-bar | calc_patch_id same &&
+ test_cmp patch-id_master patch-id_same
+'
+
+test_expect_success 'file order is irrelevant with --stable' '
+ get_patch_id_stable master &&
+ git checkout same &&
+ git format-patch -1 --stdout -O foo-then-bar | calc_patch_id_stable same &&
+ test_cmp patch-id_master patch-id_same
+'
+
+test_expect_success 'file order is relevant with --unstable' '
+ get_patch_id_unstable master &&
+ git checkout same &&
+ git format-patch -1 --stdout -O foo-then-bar | calc_patch_id_unstable notsame &&
+ ! test_cmp patch-id_master patch-id_notsame
+'
+
test_expect_success 'patch-id supports git-format-patch MIME output' '
get_patch_id master &&
git checkout same &&
--
MST
next prev parent reply other threads:[~2014-03-27 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 9:25 [PATCH 1/3] patch-id: make it stable against hunk reordering Michael S. Tsirkin
2014-03-27 9:25 ` [PATCH 2/3] patch-id: document new behaviour Michael S. Tsirkin
2014-03-27 9:25 ` Michael S. Tsirkin [this message]
2014-03-28 0:25 ` [PATCH 3/3] patch-id-test: test new --stable and --unstable flags Eric Sunshine
2014-03-27 16:58 ` [PATCH 1/3] patch-id: make it stable against hunk reordering Junio C Hamano
2014-03-27 17:34 ` Michael S. Tsirkin
2014-03-27 17:57 ` Michael S. Tsirkin
2014-03-27 18:03 ` Junio C Hamano
2014-03-27 18:39 ` Michael S. Tsirkin
2014-03-27 18:45 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395912239-29663-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).