From: "David A. Dalrymple (and Bhushan G. Lodha)" <dad-bgl@mit.edu>
To: git@vger.kernel.org
Cc: peff@peff.net, l.s.r@web.de
Subject: [PATCH 00/10] [RFC] pickaxe for function names
Date: Thu, 27 Mar 2014 14:50:46 -0400 [thread overview]
Message-ID: <1395946256-67124-1-git-send-email-dad-bgl@mit.edu> (raw)
This series introduces a --function-name=<pattern> option for git-log, intended
to search for commits which touch a function matching a certain pattern (a
feature we've seen requested and are interested in using ourselves).
This is our first attempt to patch git; we've tried to observe and follow the
community standards, but we would greatly appreciate feedback. We've been
working on this for a few weeks, and I just noticed that René Scharfe has done
conflicing (and better) refactoring work in diffcore-pickaxe.c a few days ago.
We'd be happy to rebase our changes and resolve the conflicts once René's
patches are committed to master, but we thought we may as well ask for comments
on the version we have working now.
Thanks for your time!
.gitattributes: specify the language used
diffcore-pickaxe.c: refactor regex compilation
diffcore-pickaxe.c: Refactor pickaxe_fn signature
diff.c/diff.h: expose userdiff_funcname
diffcore-pickaxe.c: set up funcname pattern
log: --function-name pickaxe
xdiff: add XDL_EMIT_MOREFUNCNAMES to try harder
xdiff: add XDL_EMIT_MOREHUNKHEADS to split hunks
t4213: test --function-name option
Documentation: Document --function-name usage
.gitattributes | 2 +-
Documentation/diff-options.txt | 9 +++
Documentation/gitdiffcore.txt | 17 ++++-
builtin/log.c | 2 +-
diff.c | 13 +++-
diff.h | 3 +
diffcore-pickaxe.c | 162 +++++++++++++++++++++++++++++++++++-----------
revision.c | 3 +-
t/t4213-log-function-name.sh | 73 +++++++++++++++++++++
xdiff/xdiff.h | 2 +
xdiff/xdiffi.c | 2 +-
xdiff/xemit.c | 99 ++++++++++++++++++++++------
xdiff/xemit.h | 4 +-
13 files changed, 323 insertions(+), 68 deletions(-)
next reply other threads:[~2014-03-27 18:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 18:50 David A. Dalrymple (and Bhushan G. Lodha) [this message]
2014-03-27 18:50 ` [PATCH 01/10] .gitattributes: specify the language used David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 02/10] diffcore-pickaxe.c: refactor regex compilation David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 03/10] diffcore-pickaxe.c: Refactor pickaxe_fn signature David A. Dalrymple (and Bhushan G. Lodha)
2014-04-04 11:09 ` Jakub Narębski
2014-03-27 18:50 ` [PATCH 04/10] diff.c/diff.h: expose userdiff_funcname David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 05/10] diffcore-pickaxe.c: set up funcname pattern David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 06/10] log: --function-name pickaxe David A. Dalrymple (and Bhushan G. Lodha)
2014-04-03 21:25 ` René Scharfe
2014-04-03 21:44 ` Junio C Hamano
2014-04-04 11:15 ` Jakub Narębski
2014-04-04 18:46 ` Junio C Hamano
2014-04-28 20:04 ` Bhushan Lodha
2014-03-27 18:50 ` [PATCH 07/10] xdiff: add XDL_EMIT_MOREFUNCNAMES David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 08/10] xdiff: add XDL_EMIT_MOREHUNKHEADS David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 09/10] t4213: test --function-name option David A. Dalrymple (and Bhushan G. Lodha)
2014-03-28 7:25 ` Johannes Sixt
2014-03-28 8:21 ` Eric Sunshine
2014-03-28 11:45 ` Johannes Sixt
2014-04-04 11:21 ` Jakub Narębski
2014-03-27 18:50 ` [PATCH 10/10] Documentation: Document --function-name usage David A. Dalrymple (and Bhushan G. Lodha)
2014-03-28 0:30 ` Eric Sunshine
2014-03-27 19:03 ` [PATCH 00/10] [RFC] pickaxe for function names Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395946256-67124-1-git-send-email-dad-bgl@mit.edu \
--to=dad-bgl@mit.edu \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).