* [PATCH] gitweb.conf.txt: fix typo
@ 2014-04-03 20:49 git-patch
2015-03-31 13:06 ` Jakub Narębski
0 siblings, 1 reply; 3+ messages in thread
From: git-patch @ 2014-04-03 20:49 UTC (permalink / raw)
To: git; +Cc: gitster, Jérôme Zago
From: Jérôme Zago <git-patch@agt-the-walker.net>
"build-time" is used everywhere else.
Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
---
Documentation/gitweb.conf.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
index 952f503..8b25a2f 100644
--- a/Documentation/gitweb.conf.txt
+++ b/Documentation/gitweb.conf.txt
@@ -482,7 +482,7 @@ project config. Per-repository configuration takes precedence over value
composed from `@git_base_url_list` elements and project name.
+
You can setup one single value (single entry/item in this list) at build
-time by setting the `GITWEB_BASE_URL` built-time configuration variable.
+time by setting the `GITWEB_BASE_URL` build-time configuration variable.
By default it is set to (), i.e. an empty list. This means that gitweb
would not try to create project URL (to fetch) from project name.
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb.conf.txt: fix typo
2014-04-03 20:49 [PATCH] gitweb.conf.txt: fix typo git-patch
@ 2015-03-31 13:06 ` Jakub Narębski
2015-03-31 20:28 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narębski @ 2015-03-31 13:06 UTC (permalink / raw)
To: Jérôme Zago; +Cc: git, Junio Hamano
On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote:
> From: Jérôme Zago <git-patch@agt-the-walker.net>
>
> "build-time" is used everywhere else.
>
> Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
You are right, it is variable set during build process,
not after project is built.
ACK (for what it is worth).
Acked-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Documentation/gitweb.conf.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
> index 952f503..8b25a2f 100644
> --- a/Documentation/gitweb.conf.txt
> +++ b/Documentation/gitweb.conf.txt
> @@ -482,7 +482,7 @@ project config. Per-repository configuration takes precedence over value
> composed from `@git_base_url_list` elements and project name.
> +
> You can setup one single value (single entry/item in this list) at build
> -time by setting the `GITWEB_BASE_URL` built-time configuration variable.
> +time by setting the `GITWEB_BASE_URL` build-time configuration variable.
> By default it is set to (), i.e. an empty list. This means that gitweb
> would not try to create project URL (to fetch) from project name.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb.conf.txt: fix typo
2015-03-31 13:06 ` Jakub Narębski
@ 2015-03-31 20:28 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2015-03-31 20:28 UTC (permalink / raw)
To: Jakub Narębski; +Cc: Jérôme Zago, git
Jakub Narębski <jnareb@gmail.com> writes:
> On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote:
>> From: Jérôme Zago <git-patch@agt-the-walker.net>
>>
>> "build-time" is used everywhere else.
>>
>> Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
>
> You are right, it is variable set during build process,
> not after project is built.
>
> ACK (for what it is worth).
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
Thanks; the patch is linewrapped but I can fix it up.
It is funny to see an ack to a patch that is almost a year old,
though ;-)
>
>> ---
>> Documentation/gitweb.conf.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
>> index 952f503..8b25a2f 100644
>> --- a/Documentation/gitweb.conf.txt
>> +++ b/Documentation/gitweb.conf.txt
>> @@ -482,7 +482,7 @@ project config. Per-repository configuration
>> takes precedence over value
>> composed from `@git_base_url_list` elements and project name.
>> +
>> You can setup one single value (single entry/item in this list) at build
>> -time by setting the `GITWEB_BASE_URL` built-time configuration variable.
>> +time by setting the `GITWEB_BASE_URL` build-time configuration variable.
>> By default it is set to (), i.e. an empty list. This means that gitweb
>> would not try to create project URL (to fetch) from project name.
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-31 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 20:49 [PATCH] gitweb.conf.txt: fix typo git-patch
2015-03-31 13:06 ` Jakub Narębski
2015-03-31 20:28 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).