From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 011/14] git-revert.sh: use the $( ... ) construct for command substitution Date: Wed, 16 Apr 2014 10:29:55 -0700 Message-ID: <1397669398-25410-11-git-send-email-gitter.spiros@gmail.com> References: <1397669398-25410-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 16 19:31:44 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WaTgV-0007ID-Gl for gcvg-git-2@plane.gmane.org; Wed, 16 Apr 2014 19:31:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754238AbaDPRbh (ORCPT ); Wed, 16 Apr 2014 13:31:37 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:34701 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755261AbaDPRaT (ORCPT ); Wed, 16 Apr 2014 13:30:19 -0400 Received: by mail-pb0-f47.google.com with SMTP id up15so11121296pbc.20 for ; Wed, 16 Apr 2014 10:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K72hRkAjk90gjIKgkiC/Iy0jQYqK1WqES5cWl6X7QN0=; b=RMbCdfDmmp26EMvatwKEfV2Fh8lgSq52hKerFHJGpsPyFOt+COANC+QzsOpQBqHmKj XD3tM1qhxg3TrWUYLm40Qu87MpApqfpP4310e2HOFjew54fGDvZ8st95bPhUmZysGFWE 3kE8NeD5nsXYD6D6Q3uTbGpXTpdVTPanWLdE1hj8RTHsISULSrQBQjysKjymOxM98Gcn FDLFxJdQPPItLyqgEfGHHBaWLjNPGh4IwSaD/xU2QEVBfu9kFkm7DyRAqtZbtZAFnR4T VvvIVXytsv9ubQsXhFxCM7nk2x+oHVbNzSLX2Caqpu+SQrG9xIIPfYvVDKWbmqCFG39Q JKRQ== X-Received: by 10.66.122.1 with SMTP id lo1mr10020570pab.118.1397669418583; Wed, 16 Apr 2014 10:30:18 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id z3sm113974244pas.15.2014.04.16.10.30.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Apr 2014 10:30:18 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1397669398-25410-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- contrib/examples/git-revert.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/examples/git-revert.sh b/contrib/examples/git-revert.sh index 6bf155c..7e2aad5 100755 --- a/contrib/examples/git-revert.sh +++ b/contrib/examples/git-revert.sh @@ -137,7 +137,7 @@ cherry-pick) q }' - logmsg=`git show -s --pretty=raw --encoding="$encoding" "$commit"` + logmsg=$(git show -s --pretty=raw --encoding="$encoding" "$commit") set_author_env=`echo "$logmsg" | LANG=C LC_ALL=C sed -ne "$pick_author_script"` eval "$set_author_env" -- 1.7.10.4