From: Ronnie Sahlberg <sahlberg@google.com>
To: git@vger.kernel.org
Cc: mhagger@alum.mit.edu, Ronnie Sahlberg <sahlberg@google.com>
Subject: [PATCH v2 0/2] Check for lock failures early
Date: Wed, 16 Apr 2014 11:56:51 -0700 [thread overview]
Message-ID: <1397674613-4922-1-git-send-email-sahlberg@google.com> (raw)
Callers outside of refs.c use either lock_ref_sha1() or
lock_any_ref_for_update() to lock a ref during an update.
Two of these places we do not immediately check the lock for failure
making reading the code harder.
One place we do some unrelated string manipulation fucntions before we
check for failure and the other place we rely on that write_ref_sha1()
will check the lock for failure and return an error.
These two patches updates these two places so that we immediately check the
lock for failure and act on it.
It does not change any functionality or logic but makes the code easier to
read by being more consistent.
Version 2:
* Simplify the return on error case in sequencer.c.
Ronnie Sahlberg (2):
sequencer.c: check for lock failure and bail early in fast_forward_to
commit.c: check for lock error and return early
builtin/commit.c | 8 ++++----
sequencer.c | 4 ++++
2 files changed, 8 insertions(+), 4 deletions(-)
--
1.9.1.504.g5a62d94
next reply other threads:[~2014-04-16 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 18:56 Ronnie Sahlberg [this message]
2014-04-16 18:56 ` [PATCH v2 1/2] sequencer.c: check for lock failure and bail early in fast_forward_to Ronnie Sahlberg
2014-04-16 22:03 ` Michael Haggerty
2014-04-16 18:56 ` [PATCH v2 2/2] commit.c: check for lock error and return early Ronnie Sahlberg
2014-04-16 22:06 ` Michael Haggerty
2014-04-17 21:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397674613-4922-1-git-send-email-sahlberg@google.com \
--to=sahlberg@google.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).