git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: git@vger.kernel.org
Subject: [PATCH v4 5/6] patch-id: document new behaviour
Date: Wed, 23 Apr 2014 15:15:02 +0300	[thread overview]
Message-ID: <1398255277-26303-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1398255277-26303-1-git-send-email-mst@redhat.com>

Clarify that patch ID can now be a sum of hashes, not a hash.
Document how command line and config options affect the
behaviour.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 Documentation/git-patch-id.txt | 25 ++++++++++++++++++++-----
 1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt
index 312c3b1..61d4a67 100644
--- a/Documentation/git-patch-id.txt
+++ b/Documentation/git-patch-id.txt
@@ -8,14 +8,14 @@ git-patch-id - Compute unique ID for a patch
 SYNOPSIS
 --------
 [verse]
-'git patch-id' < <patch>
+'git patch-id' [--stable | --unstable] < <patch>
 
 DESCRIPTION
 -----------
-A "patch ID" is nothing but a SHA-1 of the diff associated with a patch, with
-whitespace and line numbers ignored.  As such, it's "reasonably stable", but at
-the same time also reasonably unique, i.e., two patches that have the same "patch
-ID" are almost guaranteed to be the same thing.
+A "patch ID" is nothing but a sum of SHA-1 of the diff hunks associated with a
+patch, with whitespace and line numbers ignored.  As such, it's "reasonably
+stable", but at the same time also reasonably unique, i.e., two patches that
+have the same "patch ID" are almost guaranteed to be the same thing.
 
 IOW, you can use this thing to look for likely duplicate commits.
 
@@ -27,6 +27,21 @@ This can be used to make a mapping from patch ID to commit ID.
 
 OPTIONS
 -------
+
+--stable::
+	Use a symmetrical sum of hashes as the patch ID.
+	With this option, reordering file diffs that make up a patch or
+	splitting a diff up to multiple diffs that touch the same path
+	does not affect the ID.
+	This is the default if patchid.stable is set to true, or if patchid.stable
+	is not set and diff.orderfile is set to some value.
+
+--unstable::
+	Use a non-symmetrical sum of hashes, such that reordering
+	or splitting the patch does affect the ID.
+	This is the default if patchid.stable is set to false, or if neither patchid.stable
+	nor diff.orderfile are set.
+
 <patch>::
 	The diff to create the ID of.
 
-- 
MST

  parent reply	other threads:[~2014-04-23 12:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 12:14 [PATCH v4 1/6] diff: add a config option to control orderfile Michael S. Tsirkin
2014-04-23 12:14 ` [PATCH v4 2/6] test: add test_write_lines helper Michael S. Tsirkin
2014-04-23 17:34   ` Junio C Hamano
2014-04-23 17:58     ` Michael S. Tsirkin
2014-04-23 12:14 ` [PATCH v4 3/6] tests: new test for orderfile options Michael S. Tsirkin
2014-04-23 17:38   ` Junio C Hamano
2014-04-23 18:00     ` Michael S. Tsirkin
2014-04-23 12:15 ` [PATCH v4 4/6] patch-id: make it stable against hunk reordering Michael S. Tsirkin
2014-04-23 17:39   ` Junio C Hamano
2014-04-23 17:57     ` Michael S. Tsirkin
2014-04-23 22:05       ` Junio C Hamano
2014-04-24  6:29         ` Michael S. Tsirkin
2014-04-24 18:13           ` Junio C Hamano
2014-04-23 12:15 ` Michael S. Tsirkin [this message]
2014-04-23 12:15 ` [PATCH v4 6/6] patch-id-test: test stable and unstable behaviour Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398255277-26303-5-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).