From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 01/14] t9365-continuing-queries.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:43:53 -0700 Message-ID: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:44:29 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxTN-0008N0-Vt for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:44:26 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757053AbaDWNoS (ORCPT ); Wed, 23 Apr 2014 09:44:18 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:35738 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756189AbaDWNoN (ORCPT ); Wed, 23 Apr 2014 09:44:13 -0400 Received: by mail-pb0-f48.google.com with SMTP id md12so798198pbc.35 for ; Wed, 23 Apr 2014 06:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Ftlwq3fI0fcu6XMdLO98+UY6wdeNZlkFahmq7+eEe8o=; b=DmCLcPX6YOpsOTkP3rgp7Ud12zJW6uUivMpH6hlUMblBdU0z0MaE+7zK/NuYAs3D2W ds3rb7tVlVZSdEyUfiMF6/iTy0JIULGPKJdnWrtaR0t8qM7L44BnZ6MilZSha/wO52fX lcYE+zVyot3URHmX3Bi2psT2pF2aRYkq78gOLdDBl+nmCw5kEjrRgnAyw29SgtN+thWb ZXFa3xYDZGFLccDsxKk1dBC/8lZnyPACzley/NKVlVYzh850rqZDy9jz+NelbEMG5N0F KO+JZjR879I9Sv/fwVecOM7cE54faYOfc2d/pRcXACnVLrwwG4w30GOtnfaLKGhSHKQn qlRQ== X-Received: by 10.68.237.133 with SMTP id vc5mr55564273pbc.92.1398260652690; Wed, 23 Apr 2014 06:44:12 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:12 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- contrib/mw-to-git/t/t9365-continuing-queries.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/mw-to-git/t/t9365-continuing-queries.sh b/contrib/mw-to-git/t/t9365-continuing-queries.sh index 27e267f..0164547 100755 --- a/contrib/mw-to-git/t/t9365-continuing-queries.sh +++ b/contrib/mw-to-git/t/t9365-continuing-queries.sh @@ -9,7 +9,7 @@ test_check_precond test_expect_success 'creating page w/ >500 revisions' ' wiki_reset && - for i in `test_seq 501` + for i in $(test_seq 501) do echo "creating revision $i" && wiki_editpage foo "revision $i
" true -- 1.7.10.4