From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 10/14] git-web--browse.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:44:02 -0700 Message-ID: <1398260646-2660-10-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:44:41 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxTY-00007a-7G for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:44:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757077AbaDWNo0 (ORCPT ); Wed, 23 Apr 2014 09:44:26 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:58030 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756189AbaDWNoY (ORCPT ); Wed, 23 Apr 2014 09:44:24 -0400 Received: by mail-pd0-f174.google.com with SMTP id y13so790348pdi.19 for ; Wed, 23 Apr 2014 06:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x4y05lkRKXjjq9wnrXWaXjVhFqJTzESxVDKFJoiWQ2g=; b=EYnyR13tjov+k/h231dpZSIPQSSXQwt4OOEqVbVbYcTCsAUi+fT5n1HIFRrqad1HUM Z0I/YUP8PSz5PW6Ky3kfoF1SSYpyJaYdtv3VuuLEkyBPJL+lSd+It31VyWuiL4qLrKtS N9WD4BhZ4GjcyEy1jlDruv8qLcRar63y2Jn/JeZRrRydJZFjj2pml76UYjYOpkozLuxG sg3bam3PR7F9+zXKX10K8vt0fK5O789tixDJZg8uh9fj0hI/FTy9C5K87OMhCtM4b6NX 8kVErV/dazXm10tJSURKxwaND0LQQVjfWuTFn3Lc9bu+j+sjkYxN3rAws5nbwf5cULVD fnMg== X-Received: by 10.68.94.164 with SMTP id dd4mr9825145pbb.161.1398260663762; Wed, 23 Apr 2014 06:44:23 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.22 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:23 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- git-web--browse.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/git-web--browse.sh b/git-web--browse.sh index ebdfba6..ae15253 100755 --- a/git-web--browse.sh +++ b/git-web--browse.sh @@ -59,7 +59,7 @@ do -b|--browser*|-t|--tool*) case "$#,$1" in *,*=*) - browser=`expr "z$1" : 'z-[^=]*=\(.*\)'` + browser=$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; @@ -71,7 +71,7 @@ do -c|--config*) case "$#,$1" in *,*=*) - conf=`expr "z$1" : 'z-[^=]*=\(.*\)'` + conf=$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; @@ -100,7 +100,7 @@ then for opt in "$conf" "web.browser" do test -z "$opt" && continue - browser="`git config $opt`" + browser="$(git config $opt)" test -z "$browser" || break done if test -n "$browser" && ! valid_tool "$browser"; then -- 1.7.10.4