From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 12/14] lib-cvs.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:44:04 -0700 Message-ID: <1398260646-2660-12-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:49:28 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxYC-0004vV-Ll for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:49:25 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756819AbaDWNp3 (ORCPT ); Wed, 23 Apr 2014 09:45:29 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:53739 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbaDWNo0 (ORCPT ); Wed, 23 Apr 2014 09:44:26 -0400 Received: by mail-pa0-f43.google.com with SMTP id bj1so777059pad.2 for ; Wed, 23 Apr 2014 06:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ceA0HJbY5bChJ/zr/BmUd+lDrr2V1nxDBXTKNKFotXk=; b=sGefFbckdKgfef78u9+BnhdzXiyJZPArUDGI/p7CGDpPLT6fNmYs/7o/XIqqGbzOyl BbaHCRJomgOCbWkhJqOYO2VhkYylEEsAZGr2DUcpDXOZcFVDHqSXM/AaHZsgKYZvaZ7l TuZuCZe8JUBb5joinYEfpX4qxAIsugn/72DmrJHAXP4l2hfzXOxtioGOshabenujgTyR OZPuLYkWP0Tw9zwGOyrewUvU+ePbtiq3K8dFX/q3vfQr3Y0gnvRRFtvvUdVoE14tv8T4 5KiODnm6uExBdCobrRAcXChe3Mmh//p0MO2oBVgiOKZl7ynsqnHLLeRSmytB5v4SJvbm r6bw== X-Received: by 10.68.113.68 with SMTP id iw4mr20638210pbb.119.1398260665932; Wed, 23 Apr 2014 06:44:25 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.24 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:25 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/lib-cvs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/lib-cvs.sh b/t/lib-cvs.sh index 5076718..9b2bcfb 100644 --- a/t/lib-cvs.sh +++ b/t/lib-cvs.sh @@ -13,7 +13,7 @@ fi CVS="cvs -f" export CVS -cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'` +cvsps_version=$(cvsps -h 2>&1 | sed -ne 's/cvsps version //p') case "$cvsps_version" in 2.1 | 2.2*) ;; -- 1.7.10.4