From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 14/14] p5302-pack-index.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:44:06 -0700 Message-ID: <1398260646-2660-14-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:44:41 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxTZ-00007a-6Y for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:44:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757087AbaDWNoc (ORCPT ); Wed, 23 Apr 2014 09:44:32 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:64953 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757080AbaDWNo2 (ORCPT ); Wed, 23 Apr 2014 09:44:28 -0400 Received: by mail-pd0-f169.google.com with SMTP id fp1so787700pdb.14 for ; Wed, 23 Apr 2014 06:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jBf+sigiV4yjgjZjbAtK4kC/JxdbkfcJ3xZcjKjvYMw=; b=IeX2cAH0hNGPH9jjlwLmvsVnS0QeqZXKxPm9bpZp16muD35FLQJKRbQwbkL3rUPRzp PQsPqUn0gLmyGxVdI0r0PjFRz/sGoYT/P6ohr54UoUXj0IFLS3HrPOIiHIs3es/yTNOi eJ9bU6Px50hGMekxD+fpjhbrj9Nw2SQR4rNxmKEheXX7wFXJdp6BjyaHn2Xtoxt6GE8h hAfn20nDGHhVfmgKc4tEXiMZrwdG3EIaPZDP/2gXRVlw6jqj0XliRLNNnAf17j8qf0mu I2mXp1kK6auQ3G74ji6IVBu2Jvdi7M43tj0CIZh05LGWfkPl9h1GYTraSphMhj38/7fU ZPsA== X-Received: by 10.68.237.133 with SMTP id vc5mr55566741pbc.92.1398260667938; Wed, 23 Apr 2014 06:44:27 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.26 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:27 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/perf/p5302-pack-index.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh index 6cb5b0d..5ee9211 100755 --- a/t/perf/p5302-pack-index.sh +++ b/t/perf/p5302-pack-index.sh @@ -8,7 +8,7 @@ test_perf_large_repo test_expect_success 'repack' ' git repack -ad && - PACK=`ls .git/objects/pack/*.pack | head -n1` && + PACK=$(ls .git/objects/pack/*.pack | head -n1) && test -f "$PACK" && export PACK ' -- 1.7.10.4