From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 03/14] t7900-subtree.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:43:55 -0700 Message-ID: <1398260646-2660-3-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:49:38 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxYP-00056p-Df for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:49:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756430AbaDWNtb (ORCPT ); Wed, 23 Apr 2014 09:49:31 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:47731 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754714AbaDWNoP (ORCPT ); Wed, 23 Apr 2014 09:44:15 -0400 Received: by mail-pa0-f42.google.com with SMTP id fa1so275611pad.15 for ; Wed, 23 Apr 2014 06:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=drIUR2Sruy9/N0MB8MEE2BBNqRSuljWlW3k4pBvE2SY=; b=MFhG7iyNrMAJu/y1Ab5XUaFgHsPUxyucDSv4los241xVlHgJ3kyukwFi2MeySpBPYs P3RSmOGTe2/mtWAHMK009sEAqTbP6aNGSsIGR38krRFBkJqaIvAlyh836KEnmhnFuTSD w+s7tqvF47eblaD7sQ3SklG7W9icqStkpQ6XS0o3UzZj1+tMFF95qicjHvdByfRCdxyo DUYP+8mF6ndKAjuR610hNMUEkW09HAYylnmqYQGuH9Mm24mu7mu2dRY54wvbAKbfpJnm NHkZ7HQBDm8IRdU0iBck7z+QUG9NLeRrVbZatdqLC6AS3c2IEDrHRRDqJCoN5+7yAONG 9fPA== X-Received: by 10.68.194.202 with SMTP id hy10mr55450447pbc.94.1398260654970; Wed, 23 Apr 2014 06:44:14 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.13 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:14 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- contrib/subtree/t/t7900-subtree.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh index 66ce4b0..b22b710 100755 --- a/contrib/subtree/t/t7900-subtree.sh +++ b/contrib/subtree/t/t7900-subtree.sh @@ -76,7 +76,7 @@ test_expect_success 'add sub1' ' # Save this hash for testing later. -subdir_hash=`git rev-parse HEAD` +subdir_hash=$(git rev-parse HEAD) test_expect_success 'add sub2' ' create sub2 && -- 1.7.10.4