From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/14] txt-to-pot.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:43:57 -0700 Message-ID: <1398260646-2660-5-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:44:40 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxTU-0008US-9r for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:44:32 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757069AbaDWNoX (ORCPT ); Wed, 23 Apr 2014 09:44:23 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:56826 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756189AbaDWNoT (ORCPT ); Wed, 23 Apr 2014 09:44:19 -0400 Received: by mail-pa0-f48.google.com with SMTP id hz1so777921pad.35 for ; Wed, 23 Apr 2014 06:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M6I0rspgOgINzZL8IxX+QEzTDGwpztOn/m2273oNZAw=; b=mADDYijnCFduHZ0jpJ1XGLV3aD1nPnbXUwKspRxdCRLMCMybTusCXOQo0FBnwzJEDC fDtO6/Mj2MS0lAiJ07zichNcq+dYyMTPLJXn9ZnJ0XvpvgjaEsxfg/3SSX4oupKxBV3i +RLi4S/JywumG7TD50VSkrgs5ZPi6cuPzCnvftOs4gb3PuwOrzNiz4O6Pk2aCGVtfi11 SoiEau5glpuN9NDDdL198Q/PKa6wR2iJcPenax9S6jbl0doVt4VofyF5Zs6T/B3ff/1o m4edDHTnVOtC2y3pru71/lMv0p3XB3W8ZSOfSa+4smdLfnhNIR+aJQarJcLeA0I2NPna xEQA== X-Received: by 10.68.103.165 with SMTP id fx5mr25055365pbb.118.1398260658953; Wed, 23 Apr 2014 06:44:18 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.16 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:18 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- git-gui/po/glossary/txt-to-pot.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-gui/po/glossary/txt-to-pot.sh b/git-gui/po/glossary/txt-to-pot.sh index 49bf7c5..8249915 100755 --- a/git-gui/po/glossary/txt-to-pot.sh +++ b/git-gui/po/glossary/txt-to-pot.sh @@ -11,7 +11,7 @@ if [ $# -eq 0 ] then cat < git-gui-glossary.pot +Usage: $(basename $0) git-gui-glossary.txt > git-gui-glossary.pot ! exit 1; fi @@ -33,7 +33,7 @@ cat <\n" "Language-Team: LANGUAGE \n" -- 1.7.10.4