From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 06/14] git-pull.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:43:58 -0700 Message-ID: <1398260646-2660-6-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:45:33 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxUT-000144-H1 for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:45:33 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757062AbaDWNoW (ORCPT ); Wed, 23 Apr 2014 09:44:22 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:41381 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757059AbaDWNoU (ORCPT ); Wed, 23 Apr 2014 09:44:20 -0400 Received: by mail-pd0-f175.google.com with SMTP id x10so784717pdj.6 for ; Wed, 23 Apr 2014 06:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lqyKgqCx+uQE4jg9UTKKs2Acbg3HfjLmkAqF4R4580s=; b=CXpN3bxCeoQHgNMgdR3Gdtd2wQkPwaOGcyGRhboeBpRhQmwBQMqHPMfTeClqGr6hg9 E/802l7rXbEC31H2H4Eg2mfSt25rPvgTqOBJxV01OvBES6yg0+cg2AT8HMdi7wgg4oee PvrtVhBzLvB0kR8q9YCoiKzeQVFDAxOZqMqKxyCtD+ff/n249x8KC/RXMhmZiTdPOsG5 khLgvWP5F/W3XxnIgB/PbB5IecXYB7b1e9QRc/FnvTxNzjWkYgvsgVqZgYPPovMM+fDp IjHVv2M/87VRLAAVZkDMhCRN6BcPDXM83oEwL0ZQJvqHbjJP+oMZO2TH8X1wSU2JMgrl 8Fhg== X-Received: by 10.68.220.103 with SMTP id pv7mr34868169pbc.17.1398260659864; Wed, 23 Apr 2014 06:44:19 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.18 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:19 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- git-pull.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-pull.sh b/git-pull.sh index 6cd8ebc..cfc589d 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -108,7 +108,7 @@ do -s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy) case "$#,$1" in *,*=*) - strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;; + strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; *) -- 1.7.10.4