From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 08/14] git-rebase.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:44:00 -0700 Message-ID: <1398260646-2660-8-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:45:41 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxUZ-0001AZ-R1 for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:45:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757143AbaDWNpd (ORCPT ); Wed, 23 Apr 2014 09:45:33 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:40313 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757061AbaDWNoW (ORCPT ); Wed, 23 Apr 2014 09:44:22 -0400 Received: by mail-pb0-f54.google.com with SMTP id ma3so803861pbc.27 for ; Wed, 23 Apr 2014 06:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=m0Gigpif38eGbtvTIX+xCKfiBp0C7T8P4IY8+ihbGSo=; b=rpLTMmYs1916jR0heVh4TRzjYyY62o/1gXSUrvjYDxdIaZAmrMIwO0qB15Ufrs0pFL UlQAEzL5+cLPWIQEx6TV1HG+gaLreXsxOuEn8UwYTho3fJcEKArfqtZwM8g5h9bjIXGF SZeSClv1FHZOPtTk81hnRFbFgtSc2KTR5sCCEgnYMe42419j/ZxoSXYSTRoBdzX04v36 YcWU7c5f/wkaI/eC7DoujTc5ZinTKRleXoTNZEb8Pdo0PJs2ddq7XGfikDKGt/6Cij2A 7XGiaaJRBnA45xhOpY7m9WvLc10K8/0TZEtT9DB0YCqP8CWo0Vn/xZRES3NZe7AteMjC GGlg== X-Received: by 10.68.164.4 with SMTP id ym4mr55952783pbb.53.1398260661859; Wed, 23 Apr 2014 06:44:21 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.20 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:21 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- git-rebase.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index 4543815..5c7a0a1 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -457,8 +457,8 @@ then else if test -z "$onto" then - empty_tree=`git hash-object -t tree /dev/null` - onto=`git commit-tree $empty_tree