From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 09/14] git-stash.sh: use the $( ... ) construct for command substitution Date: Wed, 23 Apr 2014 06:44:01 -0700 Message-ID: <1398260646-2660-9-git-send-email-gitter.spiros@gmail.com> References: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 23 15:45:43 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WcxUZ-0001AZ-AT for gcvg-git-2@plane.gmane.org; Wed, 23 Apr 2014 15:45:39 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757141AbaDWNpb (ORCPT ); Wed, 23 Apr 2014 09:45:31 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:39437 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756361AbaDWNoX (ORCPT ); Wed, 23 Apr 2014 09:44:23 -0400 Received: by mail-pd0-f179.google.com with SMTP id g10so788789pdj.38 for ; Wed, 23 Apr 2014 06:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OFX0CxBJ/y4zCaC1U0MdeMzULSOwsP4gRpCMzroEokg=; b=sAE5+vrYo0D2s5B9EqyhS8Qj5kELKIfSNW8OoRtbkQ0To1c96dv6ii2VYeMouC/u99 ZnjxPd1wG8yRgaeU9rGSVwT7wPdibbWxF333EmHwjQhBbQvUvCXMgiAqasDycTfdwDeQ LpERVwkGeQjYJaRCCiA4VEEv/cIemPOta7FC/OgWFs+hevlKktPRxFiSGfyCKZN1ifp/ NfsjbOlPhRg8SG2OtamlMwhdwosTzTAQJQcI8L17upRmEUYgQ/hFWWB+3mGHVvZwkEaL tTMc+9S88SXHOiZmbb0GukFQ1mQpoGlBQKF+xroqlDpeZV0eWYcESuMJPAYlNMk+RSi0 GXsg== X-Received: by 10.68.139.137 with SMTP id qy9mr55201110pbb.11.1398260662846; Wed, 23 Apr 2014 06:44:22 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id kt8sm5314475pab.7.2014.04.23.06.44.21 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 23 Apr 2014 06:44:22 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398260646-2660-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- git-stash.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-stash.sh b/git-stash.sh index 4798bcf..af549c7 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -13,7 +13,7 @@ USAGE="list [] SUBDIRECTORY_OK=Yes OPTIONS_SPEC= -START_DIR=`pwd` +START_DIR=$(pwd) . git-sh-setup . git-sh-i18n require_work_tree -- 1.7.10.4