From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/14] t0026-eol-config.sh: use the $( ... ) construct for command substitution Date: Mon, 28 Apr 2014 05:57:28 -0700 Message-ID: <1398689857-17014-5-git-send-email-gitter.spiros@gmail.com> References: <1398689857-17014-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Apr 28 14:58:43 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wel8s-0004Z1-EX for gcvg-git-2@plane.gmane.org; Mon, 28 Apr 2014 14:58:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755698AbaD1M5u (ORCPT ); Mon, 28 Apr 2014 08:57:50 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:49102 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755610AbaD1M5q (ORCPT ); Mon, 28 Apr 2014 08:57:46 -0400 Received: by mail-pa0-f43.google.com with SMTP id rd3so3927391pab.16 for ; Mon, 28 Apr 2014 05:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=isAoxaKnIFcZmiQ3wL9ky5iMFqbpC5IgjNsjDe2XkJs=; b=pAodjq9Tg3D+yXTmJfxgjSvpDnCibaM/RHLBnO1YgyKSvUnGzZOgYN3KdXnkdN1DI0 S3BZZW6W0kNFTIwZpwy/VTtA2iUXL8IH8tINq4UD5sd66MgG1TD6gHEs0EQFBCLWhhKn SCFu+Gm8WQG2wVCOZw67V/4ZMys4kV9WvvrnZXnqHNcmNsKzNKVUvgQo+FhmohIbulfm 2Sw6M2zf+gI+uE1QQ8Af3vNrWyjV2JjIhvP24OdxBids6xUXmF0A+S/H+qWjCSmzX2zd cDuS9YVc7gXQw70q8yHE7qt9zSFgvmELU1Sv6z6Ado9IcPi9EpmrM1h23GkOY+9NzhHg FbNA== X-Received: by 10.68.254.103 with SMTP id ah7mr3125052pbd.159.1398689866550; Mon, 28 Apr 2014 05:57:46 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id ky8sm34896290pbc.64.2014.04.28.05.57.45 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Apr 2014 05:57:46 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398689857-17014-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t0026-eol-config.sh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh index fe0164b..e1126aa 100755 --- a/t/t0026-eol-config.sh +++ b/t/t0026-eol-config.sh @@ -20,8 +20,8 @@ test_expect_success setup ' git commit -m initial && - one=`git rev-parse HEAD:one` && - two=`git rev-parse HEAD:two` && + one=$(git rev-parse HEAD:one) && + two=$(git rev-parse HEAD:two) && echo happy. ' @@ -34,8 +34,8 @@ test_expect_success 'eol=lf puts LFs in normalized file' ' ! has_cr one && ! has_cr two && - onediff=`git diff one` && - twodiff=`git diff two` && + onediff=$(git diff one) && + twodiff=$(git diff two) && test -z "$onediff" -a -z "$twodiff" ' @@ -47,8 +47,8 @@ test_expect_success 'eol=crlf puts CRLFs in normalized file' ' has_cr one && ! has_cr two && - onediff=`git diff one` && - twodiff=`git diff two` && + onediff=$(git diff one) && + twodiff=$(git diff two) && test -z "$onediff" -a -z "$twodiff" ' @@ -61,8 +61,8 @@ test_expect_success 'autocrlf=true overrides eol=lf' ' has_cr one && has_cr two && - onediff=`git diff one` && - twodiff=`git diff two` && + onediff=$(git diff one) && + twodiff=$(git diff two) && test -z "$onediff" -a -z "$twodiff" ' @@ -75,8 +75,8 @@ test_expect_success 'autocrlf=true overrides unset eol' ' has_cr one && has_cr two && - onediff=`git diff one` && - twodiff=`git diff two` && + onediff=$(git diff one) && + twodiff=$(git diff two) && test -z "$onediff" -a -z "$twodiff" ' -- 1.7.10.4