From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 10/14] t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitution Date: Wed, 30 Apr 2014 09:23:03 -0700 Message-ID: <1398874987-14873-10-git-send-email-gitter.spiros@gmail.com> References: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 30 18:24:46 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WfXJN-0003QJ-7L for gcvg-git-2@plane.gmane.org; Wed, 30 Apr 2014 18:24:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965072AbaD3QXm (ORCPT ); Wed, 30 Apr 2014 12:23:42 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:36257 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965068AbaD3QXk (ORCPT ); Wed, 30 Apr 2014 12:23:40 -0400 Received: by mail-pd0-f173.google.com with SMTP id p10so1988191pdj.18 for ; Wed, 30 Apr 2014 09:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aO6FQWDOw5g2MjVpG+J6SdD/SpOEdH48dUo4f39myTk=; b=cWz0GC4JeDWPmwRGeurC915+JenLXdAjtOo3K5zREOEmay5dTc4OrIbQoUsvzh/DqZ wiMLFdYIxfwiAmWJROQP1coXrbk9baBR8lxiNlc5nwjFUDUo+mxJgD4KntEjFg4CH+F3 UqaAXhnVErN2hLJQ8UBGN8RNMyaQhQp+cJcaNHrGHQDmrOmpreMKbrPaWT5bVQ2iIG2D qMLA2DhrJjIEkdqqiykV7jojaM89P8EvTWPfJjjm/xjvJSmDwrFbHTlA5tCGXzH1VDms BH06AbCyAddq8RoLL9XeuGCr51GsxN/MS20ws2FGYuFg6U17nL1+jsr2NYElMXJMc918 szqA== X-Received: by 10.67.23.135 with SMTP id ia7mr10307636pad.5.1398875019875; Wed, 30 Apr 2014 09:23:39 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id te2sm138674233pac.25.2014.04.30.09.23.38 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 09:23:39 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t4057-diff-combined-paths.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4057-diff-combined-paths.sh b/t/t4057-diff-combined-paths.sh index 097e632..dff36b7 100755 --- a/t/t4057-diff-combined-paths.sh +++ b/t/t4057-diff-combined-paths.sh @@ -5,7 +5,7 @@ test_description='combined diff show only paths that are different to all parent . ./test-lib.sh # verify that diffc.expect matches output of -# `git diff -c --name-only HEAD HEAD^ HEAD^2` +# $(git diff -c --name-only HEAD HEAD^ HEAD^2) diffc_verify () { git diff -c --name-only HEAD HEAD^ HEAD^2 >diffc.actual && test_cmp diffc.expect diffc.actual -- 1.7.10.4