From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 14/14] t5000-tar-tree.sh: use the $( ... ) construct for command substitution Date: Wed, 30 Apr 2014 09:23:07 -0700 Message-ID: <1398874987-14873-14-git-send-email-gitter.spiros@gmail.com> References: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 30 18:24:13 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WfXIp-0002fn-MC for gcvg-git-2@plane.gmane.org; Wed, 30 Apr 2014 18:24:12 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965100AbaD3QXr (ORCPT ); Wed, 30 Apr 2014 12:23:47 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:62985 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965077AbaD3QXo (ORCPT ); Wed, 30 Apr 2014 12:23:44 -0400 Received: by mail-pa0-f46.google.com with SMTP id kp14so2187234pab.19 for ; Wed, 30 Apr 2014 09:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=phO6rCYX5hPG3u92VuDnmcAsbjkzDV67Tu6LM0WZpCg=; b=XjS7XVKCBmVfGlDHiPTfaxV3d4rVI91d0lZ53U9+CRXYBOvp9zQCbF8htEFNl8WIeK n0GcRgXhpaOfhxLvjHDwunwi2DhPgQHxnHfhwN53s6IQ2SFo0g4u1Z1gPJtvHjfTDShw Ye2wUEQ+uc+h3gSq3CSwyRVr9I8lyuWV6zmJUGkVWKt8k8bJUQR9/o8y3MSu8gdbaXDi S4g62dnSqx5eax8ZWM9mfxd5f5u4vhDyRViYS0Nw/PCQhRPav20JrqEW0NWLgMbbJMP6 lTseq1VNZDDAbMET8MgJVlVYkSxYTRWTyjol0iALW92ct1J7hO1Gfx/utUnKiF9hUZOF KuoA== X-Received: by 10.66.249.233 with SMTP id yx9mr10291814pac.3.1398875023825; Wed, 30 Apr 2014 09:23:43 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id te2sm138674233pac.25.2014.04.30.09.23.42 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 09:23:43 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5000-tar-tree.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh index 1cf0a4e..74fc5a8 100755 --- a/t/t5000-tar-tree.sh +++ b/t/t5000-tar-tree.sh @@ -123,7 +123,7 @@ test_expect_success \ 'add files to repository' \ 'find a -type f | xargs git update-index --add && find a -type l | xargs git update-index --add && - treeid=`git write-tree` && + treeid=$(git write-tree) && echo $treeid >treeid && git update-ref HEAD $(TZ=GMT GIT_COMMITTER_DATE="2005-05-27 22:00:00" \ git commit-tree $treeid remote.tar && test_must_fail git archive --remote=. $sha1 >remote.tar @@ -215,7 +215,7 @@ test_expect_success 'clients cannot access unreachable commits' ' test_expect_success 'upload-archive can allow unreachable commits' ' test_commit unreachable1 && - sha1=`git rev-parse HEAD` && + sha1=$(git rev-parse HEAD) && git reset --hard HEAD^ && git archive $sha1 >remote.tar && test_config uploadarchive.allowUnreachable true && -- 1.7.10.4