From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 03/14] t4006-diff-mode.sh: use the $( ... ) construct for command substitution Date: Wed, 30 Apr 2014 09:22:56 -0700 Message-ID: <1398874987-14873-3-git-send-email-gitter.spiros@gmail.com> References: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 30 18:23:46 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WfXIP-000217-8x for gcvg-git-2@plane.gmane.org; Wed, 30 Apr 2014 18:23:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965065AbaD3QXk (ORCPT ); Wed, 30 Apr 2014 12:23:40 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:53901 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965044AbaD3QXg (ORCPT ); Wed, 30 Apr 2014 12:23:36 -0400 Received: by mail-pd0-f176.google.com with SMTP id y10so1894998pdj.35 for ; Wed, 30 Apr 2014 09:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BzyZCYOOMmSKJQwmq4TjkR55ClnX60nbFajILGfwJyA=; b=Dro9saWxjm2XZPH+jz1+aqXMaKxEajfqjtkGHWuvVglQmO+iUpdXLm2vaGr2n+yiVc VR4fv2rhsE73a/4hn5QydKInIAAq9/DbVt7iDXSBAiI3VYPsIYpRnJSS689yvNIGhPV4 bSdTTApBblyvmSlj38rpdtgdnJb1wQUtfvVXNXqDu6hgSiNcbY1tzapPdBkRiLA5zyqZ 5JPAHfweQMlpIR9TinQ0U6sIJkWgUEZtbb1bdG858RfDbUANqdgviqQ1IAO/E82dXxo0 cI7x9AgurfV0vE37suUqx6NMqetW7lvy+Qnwjh6wB3nIxUVGyTXzfNUhtRH6zEvBVISA FwAQ== X-Received: by 10.66.243.131 with SMTP id wy3mr10512464pac.32.1398875013072; Wed, 30 Apr 2014 09:23:33 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id te2sm138674233pac.25.2014.04.30.09.23.32 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 09:23:32 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t4006-diff-mode.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4006-diff-mode.sh b/t/t4006-diff-mode.sh index 0591149..76f643b 100755 --- a/t/t4006-diff-mode.sh +++ b/t/t4006-diff-mode.sh @@ -13,7 +13,7 @@ sed_script='s/\(:100644 100755\) \('"$_x40"'\) \2 /\1 X X /' test_expect_success 'setup' ' echo frotz >rezrov && git update-index --add rezrov && - tree=`git write-tree` && + tree=$(git write-tree) && echo $tree ' -- 1.7.10.4