From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: =?UTF-8?q?=5BPATCH=2008/14=5D=20t4036-format-patch-signer-mime=2Esh=3A=20use=20the=20=24=28=20=2E=2E=2E=20=29=20construct=20for=20command=20substitution?= Date: Wed, 30 Apr 2014 09:23:01 -0700 Message-ID: <1398874987-14873-8-git-send-email-gitter.spiros@gmail.com> References: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 30 18:24:48 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WfXJP-0003QJ-0x for gcvg-git-2@plane.gmane.org; Wed, 30 Apr 2014 18:24:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945931AbaD3QYW convert rfc822-to-quoted-printable (ORCPT ); Wed, 30 Apr 2014 12:24:22 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:52389 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965069AbaD3QXm (ORCPT ); Wed, 30 Apr 2014 12:23:42 -0400 Received: by mail-pa0-f52.google.com with SMTP id kx10so2278055pab.39 for ; Wed, 30 Apr 2014 09:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=AipuY6Tin6uARGlHuINJUwBpt2EDyZQDny3GxS85p+k=; b=QLGy8zb5o9lFZWoVmxt5K+Pk23TgJlqqIXSLi5gZyUYMvf1h37POhlE5gRc6IBvuDO gkn2eOjnVnvNg72NTDaPQ+nM9EqIb+G0XH8p9ST2VcpGl4S8neglyzLcK9xuCFIGkJ/6 obqQM9f41seQ2UICoHLGTHt4NYQAiYUuo/dsYFhqG8dWYWZYI6kKzoOrlwWYWv9D1hyA 03uUuFif6QO2LmdJNXFu79UMT2WmsJNhTHqsunH3QVbWPolGqkTdfTjhUnqOZqulYqwl CGuYV9VEA2UZRqXm/AokxoosVvblc67BHPmyqn/F8opnHVp0ingRQnYciM5MN4AMawCS LcXg== X-Received: by 10.66.150.69 with SMTP id ug5mr10238186pab.55.1398875017816; Wed, 30 Apr 2014 09:23:37 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id te2sm138674233pac.25.2014.04.30.09.23.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 09:23:37 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t4036-format-patch-signer-mime.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4036-format-patch-signer-mime.sh b/t/t4036-format-patch= -signer-mime.sh index ba43f18..98d9713 100755 --- a/t/t4036-format-patch-signer-mime.sh +++ b/t/t4036-format-patch-signer-mime.sh @@ -42,7 +42,7 @@ test_expect_success 'attach and signoff do not duplic= ate mime headers' ' =20 GIT_COMMITTER_NAME=3D"=E3=81=AF=E3=81=BE=E3=81=AE =E3=81=B5=E3=81=AB=E3= =81=8A=E3=81=86" \ git format-patch -s --stdout -1 --attach >output && - test `grep -ci ^MIME-Version: output` =3D 1 + test $(grep -ci ^MIME-Version: output) =3D 1 =20 ' =20 --=20 1.7.10.4