From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 09/14] t4038-diff-combined.sh: use the $( ... ) construct for command substitution Date: Wed, 30 Apr 2014 09:23:02 -0700 Message-ID: <1398874987-14873-9-git-send-email-gitter.spiros@gmail.com> References: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Cc: matthieu.moy@grenoble-inp.fr, Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Apr 30 18:24:48 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WfXJP-0003QJ-HP for gcvg-git-2@plane.gmane.org; Wed, 30 Apr 2014 18:24:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933685AbaD3QY3 (ORCPT ); Wed, 30 Apr 2014 12:24:29 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:33707 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965045AbaD3QXj (ORCPT ); Wed, 30 Apr 2014 12:23:39 -0400 Received: by mail-pd0-f182.google.com with SMTP id v10so1972154pde.27 for ; Wed, 30 Apr 2014 09:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GZB1APDriPou/xgIvmWsMx8Qf9mnXIMq0aN6c3JmcG0=; b=rPrTSwMh0homeW5MEHNbP/+jGhHYdeXVjSopBNAEORhMbPm6krZ3iMFbcT3qXZyph4 5ddsWKnyfPZxlqA3EjZslxF1vvHewMMcXB+251GeaR96CCCOpjqlwLC1ujCwYhW/RfGd mve/6xTEWYSF4JKNcyMrI7AbwpG00sxPElGDY/0oZci/k/I8OpzS+zuwb4F1WpAeIYrn KDBmJQPGjxO3Uf5ZtMiJz/Akh7GV9TmraDXe9DBmI/z5GE+9RcaaYLWaqQ8P5zGntBgW x38LvfBDBfgtqDtw2FFfmrBZjv+Chm/gdRhe0LHfm077hxVh4atz3h+v609ypfekLXE0 P9zw== X-Received: by 10.66.227.104 with SMTP id rz8mr10358715pac.74.1398875018808; Wed, 30 Apr 2014 09:23:38 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id te2sm138674233pac.25.2014.04.30.09.23.37 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 09:23:38 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t4038-diff-combined.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh index 1019d7b..41913c3 100755 --- a/t/t4038-diff-combined.sh +++ b/t/t4038-diff-combined.sh @@ -94,7 +94,7 @@ test_expect_success 'setup for --cc --raw' ' blob=$(echo file | git hash-object --stdin -w) && base_tree=$(echo "100644 blob $blob file" | git mktree) && trees= && - for i in `test_seq 1 40` + for i in $(test_seq 1 40) do blob=$(echo file$i | git hash-object --stdin -w) && trees="$trees$(echo "100644 blob $blob file" | git mktree)$LF" -- 1.7.10.4