From: James Denholm <nod.helm@gmail.com>
To: git@vger.kernel.org
Cc: greend@obbligato.org, apenwarr@gmail.com, gpmcgee@gmail.com,
peff@peff.net, mmogilvi_git@miniinfo.net,
James Denholm <nod.helm@gmail.com>
Subject: [PATCH v2 2/5] contrib/subtree/Makefile: Use GIT-VERSION-FILE
Date: Sat, 3 May 2014 22:49:32 +1000 [thread overview]
Message-ID: <1399121375-14727-3-git-send-email-nod.helm@gmail.com> (raw)
In-Reply-To: <1399121375-14727-2-git-send-email-nod.helm@gmail.com>
GVF is already being used in most/all other makefiles in the project,
and has been for _quite_ a while. Hence, drop file-unique gitver and
replace with GIT_VERSION.
Signed-off-by: James Denholm <nod.helm@gmail.com>
---
contrib/subtree/Makefile | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
index 87797ed..f63334b 100644
--- a/contrib/subtree/Makefile
+++ b/contrib/subtree/Makefile
@@ -6,7 +6,10 @@ mandir ?= $(prefix)/share/man
libexecdir ?= $(prefix)/libexec/git-core
man1dir ?= $(mandir)/man1
-gitver ?= $(word 3,$(shell git --version))
+../../GIT-VERSION-FILE: FORCE
+ $(MAKE) -C ../../ GIT-VERSION-FILE
+
+-include ../../GIT-VERSION-FILE
# this should be set to a 'standard' bsd-type install program
INSTALL ?= install
@@ -44,11 +47,11 @@ $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)
$(GIT_SUBTREE_XML): $(GIT_SUBTREE_TXT)
asciidoc -b docbook -d manpage -f $(ASCIIDOC_CONF) \
- -agit_version=$(gitver) $^
+ -agit_version=$(GIT_VERSION) $^
$(GIT_SUBTREE_HTML): $(GIT_SUBTREE_TXT)
asciidoc -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \
- -agit_version=$(gitver) $^
+ -agit_version=$(GIT_VERSION) $^
test:
$(MAKE) -C t/ test
@@ -56,3 +59,5 @@ test:
clean:
rm -f *~ *.xml *.html *.1
rm -rf subproj mainline
+
+.PHONY: FORCE
--
1.9.2
next prev parent reply other threads:[~2014-05-03 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 12:49 [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass James Denholm
2014-05-03 12:49 ` [PATCH v2 1/5] contrib/subtree/Makefile: scrap unused $(gitdir) James Denholm
2014-05-03 12:49 ` James Denholm [this message]
2014-05-03 12:49 ` [PATCH v2 3/5] contrib/subtree/Makefile: s/libexecdir/gitexecdir James Denholm
2014-05-03 12:49 ` [PATCH v2 4/5] contrib/subtree/Makefile: Doc-gen rules cleanup James Denholm
2014-05-03 12:49 ` [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup James Denholm
2014-05-05 5:09 ` Jeff King
2014-05-05 21:41 ` James Denholm
2014-05-05 21:49 ` Jeff King
2014-05-05 21:59 ` James Denholm
2014-05-05 5:08 ` [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass Jeff King
2014-05-05 21:54 ` James Denholm
2014-05-05 22:01 ` Jeff King
2014-05-06 12:41 ` James Denholm
-- strict thread matches above, loose matches on Subject: below --
2014-05-06 12:41 James Denholm
2014-05-06 12:41 ` [PATCH v2 2/5] contrib/subtree/Makefile: Use GIT-VERSION-FILE James Denholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399121375-14727-3-git-send-email-nod.helm@gmail.com \
--to=nod.helm@gmail.com \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gpmcgee@gmail.com \
--cc=greend@obbligato.org \
--cc=mmogilvi_git@miniinfo.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).