public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org,
	Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] revision: add --maximal-only option
Date: Fri, 23 Jan 2026 07:38:08 +0100	[thread overview]
Message-ID: <13ff1d94-401e-4fa7-b247-fe8396ca9970@kdbg.org> (raw)
In-Reply-To: <7daff220-f93a-463a-b586-dd876b51edae@gmail.com>

Am 22.01.26 um 23:15 schrieb Derrick Stolee:
> Unfortunately, it also says "print a minimal subset" which in some
> sense is correct by "it cannot be made smaller without losing
> information" but we actually choose the maximal set there, not a
> minimal set.
> ...
> You are presenting interesting overlaps of terminology and needs.
> One thing that is different about 'git rev-list --maximal-only' with
> a list of starting commits is that it wants the maximal set from
> the _union_ of the histories, instead of the _intersection_ like
> 'git merge-base --independent' does.

I don't quite understand how a union or intersection come into play
here. The difference between the two is that `git rev-list
--maximal-only` permits negative revisions as input, but `git merge-base
--independent` does not. In the case where the input is only positive
revisions, the result of --maximal-only should always be exactly
identical to --independent, right? Even if the revisions are on
disconnected histories?

-- Hannes


  parent reply	other threads:[~2026-01-23  6:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18  2:34 [PATCH] revision: add --maximal option Derrick Stolee via GitGitGadget
2026-01-18  9:05 ` Johannes Sixt
2026-01-18 18:27   ` Derrick Stolee
2026-01-19 11:15     ` Johannes Sixt
2026-01-19 16:44       ` Derrick Stolee
2026-01-19 19:05         ` Johannes Sixt
2026-01-20  0:22       ` Junio C Hamano
2026-01-22 15:08         ` Derrick Stolee
2026-01-22 16:05 ` [PATCH v2] revision: add --maximal-only option Derrick Stolee via GitGitGadget
2026-01-22 21:44   ` Junio C Hamano
2026-01-22 22:15     ` Derrick Stolee
2026-01-22 23:11       ` Junio C Hamano
2026-01-23  6:38       ` Johannes Sixt [this message]
2026-01-23 15:58         ` Junio C Hamano
2026-01-23 16:55           ` Derrick Stolee
2026-01-23 18:08             ` Junio C Hamano
2026-01-28 14:28               ` Derrick Stolee
2026-01-29  0:14                 ` Junio C Hamano
2026-01-29 14:57                   ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ff1d94-401e-4fa7-b247-fe8396ca9970@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox