From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 01/10] check_bindir: don't use the -a or -o option with the test command Date: Thu, 15 May 2014 07:21:41 -0700 Message-ID: <1400163710-28333-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu May 15 16:22:01 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WkwXo-0007Vp-Ku for gcvg-git-2@plane.gmane.org; Thu, 15 May 2014 16:22:01 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996AbaEOOV4 (ORCPT ); Thu, 15 May 2014 10:21:56 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:44775 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbaEOOVz (ORCPT ); Thu, 15 May 2014 10:21:55 -0400 Received: by mail-pb0-f43.google.com with SMTP id up15so1170278pbc.2 for ; Thu, 15 May 2014 07:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=64iHjfGfCOKD7v3ImjyWjlhOOaavERHxennMRUYMw/M=; b=ujjaWLUO/Vpa5DrViNWUX0R9igSF7nGuZvEBZwVRgSHsXJK25PKiTvqThmTn5q4aa6 OYDKQYXjRhcKEP97NsVkloP5wAR7n6ZxyByS/5AArwqKWFVzNOjHo5AyHBeFFzCAdzRV iXUdM+rj5oSld9W5bPs7u/i6aU6FUBYHRC9KHsuirwntrd8iWxo19vI8h+Gz82g6fT3j fhAmMfuNjh6LaJHMRx9M3PNtf76molXlRuH66+JCAWASBy68gALjf89kcV/lrwBKaV8d nfikFxPH81cROaEydyBfU1ef+YFkXYtttyg7ZpIvGgz/TX6dRnOe2KgBm6IRssihyUtC lTbw== X-Received: by 10.66.141.144 with SMTP id ro16mr12450804pab.131.1400163714722; Thu, 15 May 2014 07:21:54 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id sy2sm9397666pbc.28.2014.05.15.07.21.53 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 15 May 2014 07:21:53 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Even though POSIX.1 lists -a/-o as options to "test", they are marked "Obsolescent XSI". Scripts using these expressions should be converted as follow: test "$1" -a "$2" should be written as: test "$1" && test "$2" Likewise test "$1" -o "$2" should be written as: test "$1" test "$2" But note that, in test, -a has higher precedence than -o while "&&" and "||" have equal precedence in the shell. The reason for this is that the precedence rules were never well specified, and this made many sane-looking uses of "test -a/-o" problematic. For example, if $x is "=", these work according to POSIX (it's not portable, but in practice it's okay): $ test -z "$x" $ test -z "$x" && test a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly adds an implicit "-n", but this fails: $ test "$x" -o c = d bash: test: too many arguments Signed-off-by: Elia Pinto --- Inspired from this discussion http://permalink.gmane.org/gmane.comp.version-control.git/137056 check_bindir | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/check_bindir b/check_bindir index a1c4c3e..623eadc 100755 --- a/check_bindir +++ b/check_bindir @@ -2,7 +2,7 @@ bindir="$1" gitexecdir="$2" gitcmd="$3" -if test "$bindir" != "$gitexecdir" -a -x "$gitcmd" +if test "$bindir" != "$gitexecdir" && test -x "$gitcmd" then echo echo "!! You have installed git-* commands to new gitexecdir." -- 1.7.10.4