From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/10] contrib/examples/git-repack.sh: don't use the -a or -o option with the test command Date: Thu, 15 May 2014 07:21:45 -0700 Message-ID: <1400163710-28333-5-git-send-email-gitter.spiros@gmail.com> References: <1400163710-28333-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu May 15 16:22:09 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WkwXv-0007sh-KR for gcvg-git-2@plane.gmane.org; Thu, 15 May 2014 16:22:08 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754594AbaEOOWB (ORCPT ); Thu, 15 May 2014 10:22:01 -0400 Received: from mail-pb0-f50.google.com ([209.85.160.50]:40639 "EHLO mail-pb0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbaEOOV7 (ORCPT ); Thu, 15 May 2014 10:21:59 -0400 Received: by mail-pb0-f50.google.com with SMTP id ma3so1170382pbc.9 for ; Thu, 15 May 2014 07:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YGk0e6IMc+oJzHMtiIbt6Bvg09bBmfo8aPgegZoLjxw=; b=PjSegA3y3oCqnRzpm5MTwWppOI/+TTY2BklUnx8qfT+0J9TR52HOlIULowBp+fKp62 ku+eGMUdMyEhtaIzFOQuiQsZ0vdQpgtsCDsL9DiSYZ5qhtr6jVmUce70D9b2nNjF0HOV EDAKvyJ8BGNlvqNloDx7XoPcm1DDTRsDgCDPI9eAXlJGHvLb3nXyPFWHqbqyOUUENdJN fCyV0R/LebJw/PmehKgQ5TqNc/jUQjPaQLHGXXVCBxY673G9q4UCzgg+PQpYImCovqeZ gaNGjkpwrRSIq6Ucu1rtIjQmKQr/H6o788RgYyONaQUWEj1r4rSsPB78nD3txU74XHzK CzQw== X-Received: by 10.66.189.226 with SMTP id gl2mr12964748pac.65.1400163718565; Thu, 15 May 2014 07:21:58 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id sy2sm9397666pbc.28.2014.05.15.07.21.57 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 15 May 2014 07:21:58 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1400163710-28333-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Even though POSIX.1 lists -a/-o as options to "test", they are marked "Obsolescent XSI". Scripts using these expressions should be converted as follow: test "$1" -a "$2" should be written as: test "$1" && test "$2" Likewise test "$1" -o "$2" should be written as: test "$1" test "$2" But note that, in test, -a has higher precedence than -o while "&&" and "||" have equal precedence in the shell. The reason for this is that the precedence rules were never well specified, and this made many sane-looking uses of "test -a/-o" problematic. For example, if $x is "=", these work according to POSIX (it's not portable, but in practice it's okay): $ test -z "$x" $ test -z "$x" && test a = b but this doesn't $ test -z "$x" -a a = b bash: test: too many arguments because it groups "test -n = -a" and is left with "a = b". Similarly, if $x is "-f", these $ test "$x" $ test "$x" || test c = d correctly adds an implicit "-n", but this fails: $ test "$x" -o c = d bash: test: too many arguments Signed-off-by: Elia Pinto --- Inspired from this discussion http://permalink.gmane.org/gmane.comp.version-control.git/137056 contrib/examples/git-repack.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/examples/git-repack.sh b/contrib/examples/git-repack.sh index f312405..96e3fed 100755 --- a/contrib/examples/git-repack.sh +++ b/contrib/examples/git-repack.sh @@ -76,8 +76,8 @@ case ",$all_into_one," in existing="$existing $e" fi done - if test -n "$existing" -a -n "$unpack_unreachable" -a \ - -n "$remove_redundant" + if test -n "$existing" && test -n "$unpack_unreachable" && \ + test -n "$remove_redundant" then # This may have arbitrary user arguments, so we # have to protect it against whitespace splitting -- 1.7.10.4