From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v3] format-patch --signature-file <file>
Date: Sat, 17 May 2014 09:02:21 -0700 [thread overview]
Message-ID: <1400342542-11256-1-git-send-email-jmmahler@gmail.com> (raw)
v3 patch to add format-patch --signature-file <file> option.
This revision includes changes suggested by Jeff King:
- Instead of a custom OPTION_CALLBACK, use OPT_FILENAME which
correctly resolves file names which are not evaluated by the
shell such as "--signature-file=<file>"
- Use strbuf_read_file() which eliminates the arbitrary size limit
and simplifies the code.
- Generate an error if the file cannot be read instead of quietly
continuing. This is accomplished with strbuf_read_file().
- Die if both --signature and --signature-file are used.
Jeremiah Mahler (1):
format-patch --signature-file <file>
Documentation/git-format-patch.txt | 4 ++++
builtin/log.c | 13 +++++++++++++
t/t4014-format-patch.sh | 28 ++++++++++++++++++++++++++++
3 files changed, 45 insertions(+)
next reply other threads:[~2014-05-17 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 16:02 Jeremiah Mahler [this message]
2014-05-17 16:02 ` [PATCH v3] format-patch --signature-file <file> Jeremiah Mahler
2014-05-18 11:20 ` Jeff King
2014-05-18 17:49 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400342542-11256-1-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).