From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v4] format-patch --signature-file <file>
Date: Sun, 18 May 2014 13:22:01 -0700 [thread overview]
Message-ID: <1400444522-15523-1-git-send-email-jmmahler@gmail.com> (raw)
v4 of patch to add format-patch --signature-file <file> option.
This revision includes more suggestions from Jeff King:
- Added a format.signaturefile config option.
- Fixed error messages, --signature and format.signature
- Fixed error checking, dies if strbuf_read_file fails.
- style: "cat > expect << EOF" to "cat >expect <<-\EOF"
- Eliminated use of fgrep, which is not used anywhere else
in the project. Possibility of portability problems.
Replaced with sed which is commonly used.
- Eliminated use of diff in favor of test_cmp.
- Removed redundant test, "--foo=bar" and "--foo bar"
- Changed to use test_must_fail instead of "!"
Jeremiah Mahler (1):
format-patch --signature-file <file>
Documentation/config.txt | 4 ++++
Documentation/git-format-patch.txt | 4 ++++
builtin/log.c | 16 ++++++++++++++++
t/t4014-format-patch.sh | 33 +++++++++++++++++++++++++++++++++
4 files changed, 57 insertions(+)
--
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
next reply other threads:[~2014-05-18 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 20:22 Jeremiah Mahler [this message]
2014-05-18 20:22 ` [PATCH v4] format-patch --signature-file <file> Jeremiah Mahler
2014-05-19 10:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400444522-15523-1-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).