git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] format-patch --signature-file <file>
@ 2014-05-18 20:22 Jeremiah Mahler
  2014-05-18 20:22 ` Jeremiah Mahler
  0 siblings, 1 reply; 3+ messages in thread
From: Jeremiah Mahler @ 2014-05-18 20:22 UTC (permalink / raw)
  To: Jeff King; +Cc: git, Jeremiah Mahler

v4 of patch to add format-patch --signature-file <file> option.

This revision includes more suggestions from Jeff King:

  - Added a format.signaturefile config option.

  - Fixed error messages, --signature and format.signature

  - Fixed error checking, dies if strbuf_read_file fails.

  - style: "cat > expect << EOF" to "cat >expect <<-\EOF"

  - Eliminated use of fgrep, which is not used anywhere else
	in the project.  Possibility of portability problems.
    Replaced with sed which is commonly used.

  - Eliminated use of diff in favor of test_cmp.

  - Removed redundant test, "--foo=bar" and "--foo bar"

  - Changed to use test_must_fail instead of "!"

Jeremiah Mahler (1):
  format-patch --signature-file <file>

 Documentation/config.txt           |  4 ++++
 Documentation/git-format-patch.txt |  4 ++++
 builtin/log.c                      | 16 ++++++++++++++++
 t/t4014-format-patch.sh            | 33 +++++++++++++++++++++++++++++++++
 4 files changed, 57 insertions(+)

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-19 10:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-18 20:22 [PATCH v4] format-patch --signature-file <file> Jeremiah Mahler
2014-05-18 20:22 ` Jeremiah Mahler
2014-05-19 10:48   ` Jeff King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).