From: "Michael S. Tsirkin" <mst@redhat.com>
To: git@vger.kernel.org
Subject: [PATCH 0/4] ack recoding in commit log
Date: Mon, 19 May 2014 00:17:45 +0300 [thread overview]
Message-ID: <1400447743-18513-1-git-send-email-mst@redhat.com> (raw)
As a maintainer, I often get patches by mail, then
acked-by,reviewed-by etc responses are sent by separate
mail.
I like making acks commits,
this way they are easy to keep track of
as part of git history.
Since response mail happens to have appropriate
subject matching the patch, it's a natural fit to
then use git rebase mechanics if we want to smash
these acks into the original commit.
I have been using these patches without any problems
for a while now, and find the approach very convenient.
Included:
rebase: new ack! action to handle ack commits
this part seems ready for merge to me,
please review and comment
git-ack: new tool to record an ack
this does not have proper documentation
and tests yet, I definitely intend to
do this but wanted to see whether people
like the UI first.
posting for early review and feedback
Note: yes, I think notes+git replace could be used for this too,
my workflow always includes a rebase with --autosquash
before publishing anyway, so dealing with ack as with any
other commit is nicer.
Michael S. Tsirkin (4):
rebase -i: add ack action
git-rebase: document ack
rebase: test ack
git-ack: record an ack
Documentation/git-rebase.txt | 45 ++++++++++++++++++++++---
contrib/git-ack | 79 ++++++++++++++++++++++++++++++++++++++++++++
git-rebase--interactive.sh | 34 +++++++++++++++----
t/t3415-rebase-autosquash.sh | 15 +++++++++
4 files changed, 161 insertions(+), 12 deletions(-)
create mode 100755 contrib/git-ack
--
MST
next reply other threads:[~2014-05-18 21:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 21:17 Michael S. Tsirkin [this message]
2014-05-18 21:17 ` [PATCH 1/4] rebase -i: add ack action Michael S. Tsirkin
2014-05-18 21:17 ` [PATCH 2/4] git-rebase: document ack Michael S. Tsirkin
2014-05-18 23:43 ` Eric Sunshine
2014-05-18 21:17 ` [PATCH 3/4] rebase: test ack Michael S. Tsirkin
2014-05-19 21:34 ` Junio C Hamano
2014-05-19 22:40 ` Michael S. Tsirkin
2014-05-20 14:38 ` Michael S. Tsirkin
2014-05-20 15:13 ` Junio C Hamano
2014-05-21 12:52 ` Michael S. Tsirkin
2014-05-21 16:54 ` Junio C Hamano
2014-05-21 17:39 ` Michael S. Tsirkin
2014-05-21 18:30 ` Junio C Hamano
2014-05-18 21:17 ` [PATCH 4/4] git-ack: record an ack Michael S. Tsirkin
2014-06-03 23:53 ` Fabian Ruch
2014-06-11 8:05 ` [PATCH 0/4] ack recoding in commit log Fabian Ruch
2014-06-11 8:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400447743-18513-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).