From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: jrnieder@gmail.com, Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 15/19] t/t5403-post-checkout-hook.sh: convert test -a/-o to && and ||
Date: Tue, 20 May 2014 06:50:28 -0700 [thread overview]
Message-ID: <1400593832-6510-16-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1400593832-6510-1-git-send-email-gitter.spiros@gmail.com>
The interaction with unary operators and operator precedence
for && and || are better known than -a and -o, and for that
reason we prefer them. Replace all existing instances
of -a and -o to save readers from the burden of thinking
about such things.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
t/t5403-post-checkout-hook.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
index 1753ef2..fc898c9 100755
--- a/t/t5403-post-checkout-hook.sh
+++ b/t/t5403-post-checkout-hook.sh
@@ -39,7 +39,7 @@ test_expect_success 'post-checkout receives the right arguments with HEAD unchan
old=$(awk "{print \$1}" clone1/.git/post-checkout.args) &&
new=$(awk "{print \$2}" clone1/.git/post-checkout.args) &&
flag=$(awk "{print \$3}" clone1/.git/post-checkout.args) &&
- test $old = $new -a $flag = 1
+ test $old = $new && test $flag = 1
'
test_expect_success 'post-checkout runs as expected ' '
@@ -52,7 +52,7 @@ test_expect_success 'post-checkout args are correct with git checkout -b ' '
old=$(awk "{print \$1}" clone1/.git/post-checkout.args) &&
new=$(awk "{print \$2}" clone1/.git/post-checkout.args) &&
flag=$(awk "{print \$3}" clone1/.git/post-checkout.args) &&
- test $old = $new -a $flag = 1
+ test $old = $new && test $flag = 1
'
test_expect_success 'post-checkout receives the right args with HEAD changed ' '
@@ -60,7 +60,7 @@ test_expect_success 'post-checkout receives the right args with HEAD changed ' '
old=$(awk "{print \$1}" clone2/.git/post-checkout.args) &&
new=$(awk "{print \$2}" clone2/.git/post-checkout.args) &&
flag=$(awk "{print \$3}" clone2/.git/post-checkout.args) &&
- test $old != $new -a $flag = 1
+ test $old != $new && test $flag = 1
'
test_expect_success 'post-checkout receives the right args when not switching branches ' '
@@ -68,7 +68,7 @@ test_expect_success 'post-checkout receives the right args when not switching br
old=$(awk "{print \$1}" clone2/.git/post-checkout.args) &&
new=$(awk "{print \$2}" clone2/.git/post-checkout.args) &&
flag=$(awk "{print \$3}" clone2/.git/post-checkout.args) &&
- test $old = $new -a $flag = 0
+ test $old = $new && test $flag = 0
'
if test "$(git config --bool core.filemode)" = true; then
--
1.7.10.4
next prev parent reply other threads:[~2014-05-20 13:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 13:50 [PATCH 00/19] convert test -a/-o to && and || patch series Elia Pinto
2014-05-20 13:50 ` [PATCH 01/19] check_bindir: convert test -a/-o to && and || Elia Pinto
2014-05-20 18:12 ` Junio C Hamano
2014-05-20 18:54 ` Junio C Hamano
2014-05-20 13:50 ` [PATCH 02/19] contrib/examples/git-clone.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 03/19] contrib/examples/git-commit.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 04/19] contrib/examples/git-merge.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 05/19] contrib/examples/git-repack.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 06/19] contrib/examples/git-resolve.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 07/19] git-bisect.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 08/19] git-mergetool.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 09/19] git-rebase--interactive.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 10/19] git-submodule.sh: " Elia Pinto
2014-05-20 14:07 ` Matthieu Moy
2014-05-20 14:39 ` Johannes Sixt
2014-05-20 13:50 ` [PATCH 11/19] t/t0025-crlf-auto.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 12/19] t/t0026-eol-config.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 13/19] t/t4102-apply-rename.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 14/19] t/t5000-tar-tree.sh: " Elia Pinto
2014-05-20 13:50 ` Elia Pinto [this message]
2014-05-20 13:50 ` [PATCH 16/19] t/t5537-fetch-shallow.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 17/19] t/t5538-push-shallow.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 18/19] t/t9814-git-p4-rename.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 19/19] t/test-lib-functions.sh: " Elia Pinto
2014-05-20 14:09 ` [PATCH 00/19] convert test -a/-o to && and || patch series Matthieu Moy
2014-05-20 17:57 ` Junio C Hamano
2014-05-20 18:22 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400593832-6510-16-git-send-email-gitter.spiros@gmail.com \
--to=gitter.spiros@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).