From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v6] format-patch --signature-file <file>
Date: Tue, 20 May 2014 18:02:49 -0700 [thread overview]
Message-ID: <1400634170-18266-1-git-send-email-jmmahler@gmail.com> (raw)
v6 of patch to add format-patch --signature-file <file> option.
This revision includes more suggestions from Jeff King and Junio C Hamano:
- Adding #define DEFAULT_SIGNATURE was a good idea but it could be
used in a way that nullifies the pointer comparison used to see if
the default has changed. So this was removed.
- The test cases depend on there being two blank lines after a
signature from a file. This is an odd problem because if --signature
or the default is used only one blank line is produced.
This problem can be addressed in another patch.
Jeremiah Mahler (1):
format-patch --signature-file <file>
Documentation/config.txt | 4 ++++
Documentation/git-format-patch.txt | 4 ++++
builtin/log.c | 16 ++++++++++++++++
t/t4014-format-patch.sh | 32 ++++++++++++++++++++++++++++++++
4 files changed, 56 insertions(+)
--
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
next reply other threads:[~2014-05-21 1:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 1:02 Jeremiah Mahler [this message]
2014-05-21 1:02 ` [PATCH v6] format-patch --signature-file <file> Jeremiah Mahler
2014-05-21 21:13 ` Junio C Hamano
2014-05-21 21:24 ` Junio C Hamano
2014-05-21 21:32 ` Jeremiah Mahler
2014-05-21 21:50 ` Jeremiah Mahler
2014-05-21 21:58 ` Junio C Hamano
2014-05-21 22:02 ` Jeff King
2014-05-21 22:15 ` Junio C Hamano
2014-05-21 22:27 ` Jeremiah Mahler
2014-05-21 22:48 ` Junio C Hamano
2014-05-21 22:12 ` Jeremiah Mahler
2014-05-21 22:37 ` Junio C Hamano
2014-05-21 23:18 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400634170-18266-1-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).