From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v8 0/2] format-patch --signature-file <file>
Date: Wed, 21 May 2014 18:53:07 -0700 [thread overview]
Message-ID: <1400723589-8975-1-git-send-email-jmmahler@gmail.com> (raw)
v8 of patch to add format-patch --signature-file <file> option.
This revision includes more suggestions from Jeff King and Junio C Hamano.
- Renamed variable which stores the signature to 'mail-signature'
which better describes what is being stored.
- Fixed a declaration after code (forbidden by ISO C90).
- Simplified sed usage in test cases from a pipeline with
three stages to just one.
- Enclosed the creation of test data ('cat >mail-signature') inside
a test_expect_* case.
- Test cases now add one blank line to the actual signature to match
the signature output of Git. Previously, the last of the output
was deleted.
Thanks again for all the suggestions.
Jeff King (1):
format-patch: make newline after signature conditional
Jeremiah Mahler (1):
format-patch --signature-file <file>
Documentation/config.txt | 4 ++++
Documentation/git-format-patch.txt | 4 ++++
builtin/log.c | 25 +++++++++++++++++++++--
t/t4014-format-patch.sh | 41 ++++++++++++++++++++++++++++++++++++++
4 files changed, 72 insertions(+), 2 deletions(-)
--
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
next reply other threads:[~2014-05-22 1:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 1:53 Jeremiah Mahler [this message]
2014-05-22 1:53 ` [PATCH v8 1/2] format-patch: make newline after signature conditional Jeremiah Mahler
2014-05-22 1:53 ` [PATCH v8 2/2] format-patch --signature-file <file> Jeremiah Mahler
2014-05-22 20:52 ` Junio C Hamano
2014-05-23 5:55 ` Jeremiah Mahler
2014-05-23 16:56 ` Junio C Hamano
2014-05-22 14:23 ` [PATCH v8 0/2] " Jeremiah Mahler
2014-05-22 19:00 ` Junio C Hamano
2014-05-22 19:41 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400723589-8975-1-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).