From: Caleb Thompson <cjaysson@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Jeremiah Mahler <jmmahler@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH v3 3/5] commit test: Use write_script
Date: Mon, 26 May 2014 13:56:24 -0500 [thread overview]
Message-ID: <1401130586-93105-4-git-send-email-caleb@calebthompson.io> (raw)
In-Reply-To: <1401130586-93105-1-git-send-email-caleb@calebthompson.io>
Use write_script from t/test-lib-functions instead of cat, shebang, and
chmod.
Signed-off-by: Caleb Thompson <caleb@calebthompson.io>
---
t/t7507-commit-verbose.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
index 3b06d73..e62d921 100755
--- a/t/t7507-commit-verbose.sh
+++ b/t/t7507-commit-verbose.sh
@@ -3,11 +3,9 @@
test_description='verbose commit template'
. ./test-lib.sh
-cat >check-for-diff <<EOF
-#!$SHELL_PATH
-exec grep '^diff --git' "\$1"
+write_script check-for-diff <<-EOF
+ exec grep '^diff --git' "\$1"
EOF
-chmod +x check-for-diff
test_set_editor "$(pwd)/check-for-diff"
cat >message <<'EOF'
--
1.9.3
next prev parent reply other threads:[~2014-05-26 18:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 6:24 [PATCH v2] commit: support commit.verbose and --no-verbose Caleb Thompson
2014-05-25 7:02 ` Jeremiah Mahler
2014-05-25 7:44 ` Jeremiah Mahler
2014-05-25 8:44 ` Duy Nguyen
2014-05-25 10:23 ` Eric Sunshine
2014-05-26 18:56 ` [PATCH v3 0/5] " Caleb Thompson
2014-05-26 18:56 ` [PATCH v3 1/5] commit test: Use test_config instead of git-config Caleb Thompson
2014-05-26 18:56 ` [PATCH v3 2/5] commit test: Change $PWD to $(pwd) Caleb Thompson
2014-05-27 5:46 ` Johannes Sixt
2014-05-27 6:10 ` Eric Sunshine
2014-05-27 6:14 ` Jeremiah Mahler
2014-05-27 6:34 ` Johannes Sixt
2014-05-27 7:35 ` David Kastrup
2014-05-26 18:56 ` Caleb Thompson [this message]
2014-05-27 22:30 ` [PATCH v3 3/5] commit test: Use write_script Eric Sunshine
2014-05-27 22:42 ` Junio C Hamano
2014-05-26 18:56 ` [PATCH v3 4/5] commit test: test_set_editor in each test Caleb Thompson
2014-05-27 22:59 ` Eric Sunshine
2014-05-26 18:56 ` [PATCH v3 5/5] commit: support commit.verbose and --no-verbose Caleb Thompson
2014-05-26 20:33 ` Jeremiah Mahler
2014-05-26 20:47 ` Caleb Thompson
[not found] ` <CA+g4mq8iGNVm-2Uj8j2bJLDazaTS_U76BO9-jeS9Aw4RZnki5A@mail.gmail.com>
2014-05-26 21:00 ` Jeremiah Mahler
2014-05-26 22:14 ` Jeremiah Mahler
2014-05-26 22:34 ` [PATCH v3 0/5] " Jeremiah Mahler
2014-05-26 22:40 ` Caleb Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401130586-93105-4-git-send-email-caleb@calebthompson.io \
--to=cjaysson@gmail.com \
--cc=git@vger.kernel.org \
--cc=jmmahler@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).