From: David Turner <dturner@twopensource.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Duy Nguyen <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
David Turner <dturner@twitter.com>
Subject: Re: [PATCH v6 2/2] refs.c: SSE4.2 optimizations for check_refname_component
Date: Wed, 04 Jun 2014 17:16:00 -0400 [thread overview]
Message-ID: <1401916560.18134.167.camel@stross> (raw)
In-Reply-To: <538F2C6B.2030004@web.de>
On Wed, 2014-06-04 at 16:25 +0200, Torsten Bögershausen wrote:
> On the other hand, looking here:
> http://sourceware.org/ml/libc-alpha/2009-10/msg00063.html
> and looking into refs.c,
> it seems as if we can try to run
> strcspn(refname, bad_characters)
> and
> strstr(refname, "@{"
> and
> strstr(refname, ".."
> on each refname, instead of checking each char in a loop.
> The library will pick the fastest version for strcspn() automatically.
Yes, you could try that, but I worry that it would be less efficient,
because it duplicates the looping machinery.
> David, the repo you run the tests on, is it public?
Unfortunately, it is an internal Twitter repo.
> Or is there a public repo with this many refs ?
I do not know of one.
> Or can you make a dummy repo with 60k refs ?
Sure! I actually went with > 120k to make measurement easier:
https://github.com/dturner-tw/many-refs
next prev parent reply other threads:[~2014-06-04 21:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 3:38 [PATCH v6 1/2] refs.c: optimize check_refname_component() David Turner
2014-06-04 3:38 ` [PATCH v6 2/2] refs.c: SSE4.2 optimizations for check_refname_component David Turner
2014-06-04 8:04 ` Torsten Bögershausen
2014-06-04 11:21 ` Duy Nguyen
2014-06-04 14:25 ` Torsten Bögershausen
2014-06-04 21:16 ` David Turner [this message]
2014-06-05 12:30 ` Torsten Bögershausen
2014-06-05 12:58 ` Ondřej Bílka
2014-06-05 19:26 ` David Turner
2014-06-05 21:42 ` Torsten Bögershausen
2014-06-05 22:02 ` David Turner
2014-06-04 21:14 ` David Turner
2014-06-04 21:46 ` Junio C Hamano
2014-06-05 19:27 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401916560.18134.167.camel@stross \
--to=dturner@twopensource.com \
--cc=dturner@twitter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).