From: Ronnie Sahlberg <sahlberg@google.com>
To: git@vger.kernel.org
Cc: Ronnie Sahlberg <sahlberg@google.com>
Subject: [PATCH v19 04/48] refs.c: allow passing NULL to ref_transaction_free
Date: Thu, 19 Jun 2014 08:52:46 -0700 [thread overview]
Message-ID: <1403193210-6028-5-git-send-email-sahlberg@google.com> (raw)
In-Reply-To: <1403193210-6028-1-git-send-email-sahlberg@google.com>
Allow ref_transaction_free(NULL) as a no-op. This makes ref_transaction_free
easier to use and more similar to plain 'free'.
In particular, it lets us rollback unconditionally as part of cleanup code
after setting 'transaction = NULL' if a transaction has been committed or
rolled back already.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
refs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/refs.c b/refs.c
index 21ed465..1d6dece 100644
--- a/refs.c
+++ b/refs.c
@@ -3338,6 +3338,9 @@ void ref_transaction_free(struct ref_transaction *transaction)
{
int i;
+ if (!transaction)
+ return;
+
for (i = 0; i < transaction->nr; i++)
free(transaction->updates[i]);
--
2.0.0.438.g337c581
next prev parent reply other threads:[~2014-06-19 15:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 15:52 [PATCH v19 00/48] Use ref transactions Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 01/48] refs.c: remove ref_transaction_rollback Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 02/48] refs.c: ref_transaction_commit should not free the transaction Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 03/48] refs.c: constify the sha arguments for ref_transaction_create|delete|update Ronnie Sahlberg
2014-06-19 15:52 ` Ronnie Sahlberg [this message]
2014-06-19 15:52 ` [PATCH v19 05/48] refs.c: add a strbuf argument to ref_transaction_commit for error logging Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 06/48] lockfile.c: add a new public function unable_to_lock_message Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 07/48] lockfile.c: make lock_file return a meaningful errno on failurei Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 08/48] refs.c: add an err argument to repack_without_refs Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 09/48] refs.c: make sure log_ref_setup returns a meaningful errno Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 10/48] refs.c: verify_lock should set errno to something meaningful Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 11/48] refs.c: make remove_empty_directories always set errno to something sane Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 12/48] refs.c: commit_packed_refs to return a meaningful errno on failure Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 13/48] refs.c: make resolve_ref_unsafe set errno to something meaningful on error Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 14/48] refs.c: log_ref_write should try to return meaningful errno Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 15/48] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 16/48] refs.c: make update_ref_write update a strbuf on failure Ronnie Sahlberg
2014-06-19 15:52 ` [PATCH v19 17/48] update-ref: use err argument to get error from ref_transaction_commit Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 18/48] refs.c: remove the onerr argument to ref_transaction_commit Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 19/48] refs.c: change ref_transaction_update() to do error checking and return status Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 20/48] refs.c: change ref_transaction_create " Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 21/48] refs.c: update ref_transaction_delete to check for error " Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 22/48] refs.c: make ref_transaction_begin take an err argument Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 23/48] refs.c: add transaction.status and track OPEN/CLOSED/ERROR Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 24/48] tag.c: use ref transactions when doing updates Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 25/48] replace.c: use the ref transaction functions for updates Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 26/48] commit.c: use ref transactions " Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 27/48] sequencer.c: use ref transactions for all ref updates Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 28/48] fast-import.c: change update_branch to use ref transactions Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 29/48] branch.c: use ref transaction for all ref updates Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 30/48] refs.c: change update_ref to use a transaction Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 31/48] receive-pack.c: use a reference transaction for updating the refs Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 32/48] fast-import.c: use a ref transaction when dumping tags Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 33/48] walker.c: use ref transaction for ref updates Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 34/48] refs.c: make lock_ref_sha1 static Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 35/48] refs.c: remove the update_ref_lock function Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 36/48] refs.c: remove the update_ref_write function Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 37/48] refs.c: remove lock_ref_sha1 Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 38/48] refs.c: make prune_ref use a transaction to delete the ref Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 39/48] refs.c: make delete_ref use a transaction Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 40/48] refs.c: add an err argument to delete_ref_loose Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 41/48] refs.c: pass the ref log message to _create/delete/update instead of _commit Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 42/48] refs.c: pass NULL as *flags to read_ref_full Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 44/48] refs.c: call lock_ref_sha1_basic directly from commit Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 45/48] refs.c: pass a skip list to name_conflict_fn Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 46/48] refs.c: propagate any errno==ENOTDIR from _commit back to the callers Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 47/48] fetch.c: change s_update_ref to use a ref transaction Ronnie Sahlberg
2014-06-19 15:53 ` [PATCH v19 48/48] refs.c: make write_ref_sha1 static Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403193210-6028-5-git-send-email-sahlberg@google.com \
--to=sahlberg@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).