From: Jeremiah Mahler <jmmahler@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH v5 0/2] cleanup duplicate name_compare() functions
Date: Thu, 19 Jun 2014 19:06:42 -0700 [thread overview]
Message-ID: <1403230004-11034-1-git-send-email-jmmahler@gmail.com> (raw)
Version 5 of the patch series to cleanup the duplicate name_compare()
functions.
- name-hash.c had a call to cache_name_compare() but it required that
the lengths were equal. Since cache_name_compare() is equivalent to
memcmp() when the lengths are equal, replace it with memcmp().
This avoids renaming cache_name_compare() to name_compare() in a
later patch.
- Cleanup of log message by Junio C Humano.
Jeremiah Mahler (2):
name-hash.c: replace cache_name_compare() with memcmp()
cleanup duplicate name_compare() functions
cache.h | 2 +-
dir.c | 3 +--
name-hash.c | 2 +-
read-cache.c | 23 +++++++++++++----------
tree-walk.c | 10 ----------
unpack-trees.c | 11 -----------
6 files changed, 16 insertions(+), 35 deletions(-)
--
2.0.0.694.g5736dad
next reply other threads:[~2014-06-20 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 2:06 Jeremiah Mahler [this message]
2014-06-20 2:06 ` [PATCH v5 1/2] name-hash.c: replace cache_name_compare() with memcmp() Jeremiah Mahler
2014-06-20 17:10 ` Junio C Hamano
2014-06-20 2:06 ` [PATCH v5 2/2] cleanup duplicate name_compare() functions Jeremiah Mahler
2014-06-20 17:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403230004-11034-1-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).