From: David Turner <dturner@twopensource.com>
To: Aidan Feldman <aidan.feldman@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: Feature request: git commit -A
Date: Tue, 24 Jun 2014 16:34:45 -0700 [thread overview]
Message-ID: <1403652885.22828.10.camel@stross> (raw)
In-Reply-To: <CAPgiXS7AizvtVNWR4dPXZ6nUQh7ujrrRFmd2SAktsUB0pidFVw@mail.gmail.com>
On Tue, 2014-06-24 at 15:01 -0400, Aidan Feldman wrote:
> Hi all-
> I work on the education team at GitHub and do a fair number of Git
> workshops. One thing that I've always found difficult to explain to
> newbies is how the staging area works, and why it's useful. As a
> hand-wave to simplify things, I usually have them use
>
> git add -A
> git commit -m "..."
>
> to not really have to worry about untracked vs. modified/removed files
> aren't included with `git commit -a` or `git add .`. I would like to
> add a `-A` flag to the `commit` command, which effectively does a `git
> add -A` before committing.
>
> I was trying to submit a patch myself, but couldn't even manage to
> find where the various flags are defined :-) Does the feature sound
> reasonable? Mind pointing me in the right direction of where this
> would be added?
Look at builtin/commit.c in the cmd_commit function. You'll see:
OPT_BOOL('a', "all", &all, N_("commit all changed files")),
Just add another one,
OPT_BOOL('A', "all-untracked", &all_untracked, N_("commit all changed
files as well as all non-excluded untracked files")),
That said, I am mildly opposed to this feature because it will
inevitably lead to cruft (and credentials) being checked into
repositories. It's easier, but it's not simpler.
prev parent reply other threads:[~2014-06-24 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 19:01 Feature request: git commit -A Aidan Feldman
2014-06-24 23:34 ` David Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403652885.22828.10.camel@stross \
--to=dturner@twopensource.com \
--cc=aidan.feldman@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).