From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH 4/4 v6] cache-tree: Write updated cache-tree after commit
Date: Fri, 11 Jul 2014 16:37:21 -0700 [thread overview]
Message-ID: <1405121841.3775.31.camel@stross> (raw)
In-Reply-To: <xmqq38e76gfi.fsf@gitster.dls.corp.google.com>
On Fri, 2014-07-11 at 08:52 -0700, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
>
> > @@ -16,8 +16,34 @@ cmp_cache_tree () {
> > # We don't bother with actually checking the SHA1:
> > # test-dump-cache-tree already verifies that all existing data is
> > # correct.
>
> Is this statement now stale and needs to be removed?
I think it is still accurate; we still don't bother to check SHAs and
test-dump-cache-tree still does the comparison.
prev parent reply other threads:[~2014-07-11 23:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 0:31 [PATCH 1/4 v6] cache-tree: Create/update cache-tree on checkout David Turner
2014-07-11 0:31 ` [PATCH 2/4 v6] test-dump-cache-tree: invalid trees are not errors David Turner
2014-07-11 0:31 ` [PATCH 3/4 v6] cache-tree: subdirectory tests David Turner
2014-07-11 6:03 ` Eric Sunshine
2014-07-11 15:27 ` Junio C Hamano
2014-07-11 15:40 ` Junio C Hamano
2014-07-11 22:46 ` David Turner
2014-07-13 16:42 ` Junio C Hamano
2014-07-11 22:46 ` David Turner
2014-07-11 0:31 ` [PATCH 4/4 v6] cache-tree: Write updated cache-tree after commit David Turner
2014-07-11 15:52 ` Junio C Hamano
2014-07-11 23:37 ` David Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405121841.3775.31.camel@stross \
--to=dturner@twopensource.com \
--cc=dturner@twitter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).