git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tanay Abhra <tanayabh@gmail.com>
To: git@vger.kernel.org
Cc: Tanay Abhra <tanayabh@gmail.com>,
	Ramkumar Ramachandra <artagnon@gmail.com>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/6] Rewrite `git_config()` using config-set API
Date: Fri, 25 Jul 2014 05:58:09 -0700	[thread overview]
Message-ID: <1406293095-15920-1-git-send-email-tanayabh@gmail.com> (raw)

[PATCH V2]: All the suggestions in [2] incorporated. git_config() now follows
	correct parsing order. Reordered the patches. Removed xfuncname patch
	as it was unnecssary.

This series builds on the top of 1d2856f (ta/config-set) in pu or topic[1]
in the mailing list with name "git config cache & special querying API utilizing
the cache".

This series aims to do these three things,

* Use the config-set API to rewrite git_config().

* Solve any legacy bugs in the previous system while at it.

* To be feature complete compared to the previous git_config() implementation,
  which I think it is now. (added the line number and file name info just for
  completeness)

Also, I haven't yet checked the exact improvements but still as a teaser,
git status now only rereads the configuration files twice instead of four
times.

[1]: http://thread.gmane.org/gmane.comp.version-control.git/253862
[2]: http://thread.gmane.org/gmane.comp.version-control.git/254101

Tanay Abhra (6):
  config.c: fix accuracy of line number in errors
  add line number and file name info to `config_set`
  rewrite git_config() to use the config-set API
  add a test for semantic errors in config files
  config: add `git_die_config()` to the config-set API
  Add tests for `git_config_get_string()`

 Documentation/technical/api-config.txt |   5 ++
 cache.h                                |  26 +++++++
 config.c                               | 135 ++++++++++++++++++++++++++++-----
 t/t1308-config-set.sh                  |  20 +++++
 test-config.c                          |  10 +++
 5 files changed, 175 insertions(+), 21 deletions(-)

-- 
1.9.0.GIT

             reply	other threads:[~2014-07-25 12:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 12:58 Tanay Abhra [this message]
2014-07-25 12:58 ` [PATCH v2 1/6] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 2/6] add line number and file name info to `config_set` Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 3/6] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-25 13:58   ` Matthieu Moy
2014-07-25 14:07     ` Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 4/6] add a test for semantic errors in config files Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 5/6] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-25 14:03   ` Matthieu Moy
2014-07-25 14:12     ` Tanay Abhra
2014-07-25 17:29       ` Junio C Hamano
2014-07-25 12:58 ` [PATCH v2 6/6] Add tests for `git_config_get_string()` Tanay Abhra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406293095-15920-1-git-send-email-tanayabh@gmail.com \
    --to=tanayabh@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).