From: Tanay Abhra <tanayabh@gmail.com>
To: git@vger.kernel.org
Cc: Tanay Abhra <tanayabh@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: [PATCH 7/7] add tests for `git_config_get_string_const()`
Date: Thu, 31 Jul 2014 02:44:17 -0700 [thread overview]
Message-ID: <1406799857-28048-8-git-send-email-tanayabh@gmail.com> (raw)
In-Reply-To: <1406799857-28048-1-git-send-email-tanayabh@gmail.com>
Add tests for `git_config_get_string_const()`, check whether it
dies printing the line number and the file name if a NULL
value is retrieved for the given key.
Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
---
t/t1308-config-set.sh | 10 ++++++++++
test-config.c | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index e2f9d0b..f012dd6 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -119,6 +119,16 @@ test_expect_success 'find integer value for a key' '
check_config get_int lamb.chop 65
'
+test_expect_success 'find string value for a key' '
+ check_config get_string case.baz hask &&
+ check_config expect_code 1 get_string case.ba "Value not found for \"case.ba\""
+'
+
+test_expect_success 'check line error when NULL string is queried' '
+ test_expect_code 128 test-config get_string case.foo 2>result &&
+ grep "fatal: bad config variable '\''case.foo'\'' at file line 7 in .git/config" result
+'
+
test_expect_success 'find integer if value is non parse-able' '
check_config expect_code 128 get_int lamb.head
'
diff --git a/test-config.c b/test-config.c
index 9dd1b22..6a77552 100644
--- a/test-config.c
+++ b/test-config.c
@@ -16,6 +16,8 @@
*
* get_bool -> print bool value for the entered key or die
*
+ * get_string -> print string value for the entered key or die
+ *
* configset_get_value -> returns value with the highest priority for the entered key
* from a config_set constructed from files entered as arguments.
*
@@ -84,6 +86,14 @@ int main(int argc, char **argv)
printf("Value not found for \"%s\"\n", argv[2]);
goto exit1;
}
+ } else if (argc == 3 && !strcmp(argv[1], "get_string")) {
+ if (!git_config_get_string_const(argv[2], &v)) {
+ printf("%s\n", v);
+ goto exit0;
+ } else {
+ printf("Value not found for \"%s\"\n", argv[2]);
+ goto exit1;
+ }
} else if (!strcmp(argv[1], "configset_get_value")) {
for (i = 3; i < argc; i++) {
int err;
--
1.9.0.GIT
prev parent reply other threads:[~2014-07-31 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 9:44 [PATCH v5 0/7] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-31 9:44 ` [PATCH v5 1/7] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-31 9:44 ` [PATCH v5 2/7] add line number and file name info to `config_set` Tanay Abhra
2014-07-31 9:44 ` [PATCH v5 3/7] change `git_config()` return value to void Tanay Abhra
2014-07-31 11:22 ` Matthieu Moy
2014-07-31 11:32 ` Matthieu Moy
2014-07-31 11:52 ` Tanay Abhra
2014-07-31 11:58 ` Matthieu Moy
2014-07-31 9:44 ` [PATCH v5 4/7] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-31 11:28 ` Matthieu Moy
2014-07-31 9:44 ` [PATCH v5 5/7] add a test for semantic errors in config files Tanay Abhra
2014-07-31 9:44 ` [PATCH 6/7] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-31 11:30 ` Matthieu Moy
2014-07-31 9:44 ` Tanay Abhra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406799857-28048-8-git-send-email-tanayabh@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).