From: Tanay Abhra <tanayabh@gmail.com>
To: git@vger.kernel.org
Cc: Tanay Abhra <tanayabh@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v9 0/8] Rewrite `git_config()` using config-set API
Date: Thu, 7 Aug 2014 04:59:11 -0700 [thread overview]
Message-ID: <1407412759-13833-1-git-send-email-tanayabh@gmail.com> (raw)
[Patch v9]: Changed the grep statements in patch 7/8 and 8/8.
[Patch v8]: git_die_config now allows custom error messages.
new tests are now not too reliant on specific strings.
[Patch v7]: style nit corrected. (1/8) is Matthieu's translation patch.
git_die_config_linenr() helper function added. Diff between v6
and v7 appended for review.
[Patch v6]: Added _(....) to error messages.
Diff between v6 and v4 at the bottom.
[PATCH v5]: New patch added (3/7). git_config() now returns void.
[PATCH v4]: One style nit corrected, also added key to error messages.
[PATCH V3]:All the suggestions in [3] applied. Built on top of [1].
[PATCH V2]: All the suggestions in [2] incorporated. git_config() now follows
correct parsing order. Reordered the patches. Removed xfuncname patch
as it was unnecssary.
This series builds on the top of topic[1] in the mailing list with name
"git config cache & special querying API utilizing the cache" or (ta/config-set in pu).
This series aims to do these three things,
* Use the config-set API to rewrite git_config().
* Solve any legacy bugs in the previous system while at it.
* To be feature complete compared to the previous git_config() implementation,
which I think it is now. (added the line number and file name info just for
completeness)
Also, I haven't yet checked the exact improvements but still as a teaser,
git status now only rereads the configuration files twice instead of four
times.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/254286
[2]: http://thread.gmane.org/gmane.comp.version-control.git/254101
[3]: http://thread.gmane.org/gmane.comp.version-control.git/254211
Matthieu Moy (1):
config.c: mark error and warnings strings for translation
Tanay Abhra (7):
config.c: fix accuracy of line number in errors
add line number and file name info to `config_set`
change `git_config()` return value to void
config: add `git_die_config()` to the config-set API
rewrite git_config() to use the config-set API
add a test for semantic errors in config files
add tests for `git_config_get_string_const()`
Documentation/technical/api-config.txt | 13 +++
branch.c | 5 +-
cache.h | 34 +++++++-
config.c | 152 +++++++++++++++++++++++++++------
t/t1308-config-set.sh | 21 +++++
t/t4055-diff-context.sh | 2 +-
test-config.c | 10 +++
7 files changed, 207 insertions(+), 30 deletions(-)
--
1.9.0.GIT
next reply other threads:[~2014-08-07 12:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 11:59 Tanay Abhra [this message]
2014-08-07 11:59 ` [PATCH v9 1/8] config.c: mark error and warnings strings for translation Tanay Abhra
2014-08-07 11:59 ` [PATCH v9 2/8] config.c: fix accuracy of line number in errors Tanay Abhra
2014-08-07 11:59 ` [PATCH v9 3/8] add line number and file name info to `config_set` Tanay Abhra
2014-08-07 19:33 ` Ramsay Jones
2014-08-07 19:56 ` Matthieu Moy
2014-08-07 20:09 ` Junio C Hamano
2014-08-07 20:11 ` Matthieu Moy
2014-08-07 11:59 ` [PATCH v9 4/8] change `git_config()` return value to void Tanay Abhra
2014-08-07 11:59 ` [PATCH v9 5/8] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-08-07 18:55 ` Junio C Hamano
2014-08-08 12:14 ` Tanay Abhra
2014-08-07 11:59 ` [PATCH v9 6/8] rewrite git_config() to use " Tanay Abhra
2014-08-07 11:59 ` [PATCH v9 7/8] add a test for semantic errors in config files Tanay Abhra
2014-08-07 11:59 ` [PATCH v9 8/8] add tests for `git_config_get_string_const()` Tanay Abhra
2014-08-07 12:15 ` [PATCH v9 0/8] Rewrite `git_config()` using config-set API Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407412759-13833-1-git-send-email-tanayabh@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).