From: Stefan Beller <stefanbeller@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Stefan Beller <stefanbeller@gmail.com>
Subject: [PATCH 2/2] clone.c: don't leak memory in cmd_clone
Date: Sun, 10 Aug 2014 15:57:56 +0200 [thread overview]
Message-ID: <1407679076-20300-2-git-send-email-stefanbeller@gmail.com> (raw)
In-Reply-To: <1407679076-20300-1-git-send-email-stefanbeller@gmail.com>
Free the refspec.
Found by scan.coverity.com (Id: 1127806)
Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
---
builtin/clone.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c
index bbd169c..dd4092b 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -1004,5 +1004,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
strbuf_release(&key);
strbuf_release(&value);
junk_mode = JUNK_LEAVE_ALL;
+
+ free(refspec);
return err;
}
--
2.1.0.rc2
next prev parent reply other threads:[~2014-08-10 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 13:57 [PATCH 1/2] remote.c: don't leak the base branch name in format_tracking_info Stefan Beller
2014-08-10 13:57 ` Stefan Beller [this message]
2014-08-10 15:14 ` Stefan Beller
2014-08-10 19:32 ` Jeff King
2014-08-10 19:43 ` [PATCH] " Stefan Beller
2014-08-10 23:03 ` [PATCH 1/2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407679076-20300-2-git-send-email-stefanbeller@gmail.com \
--to=stefanbeller@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).