From: Stefan Beller <stefanbeller@gmail.com>
To: gitster@pobox.com, git@vger.kernel.org
Cc: Stefan Beller <stefanbeller@gmail.com>
Subject: [PATCH] mailsplit.c: remove dead code
Date: Mon, 11 Aug 2014 23:11:21 +0200 [thread overview]
Message-ID: <1407791481-17410-1-git-send-email-stefanbeller@gmail.com> (raw)
This was found by coverity. (Id: 290001)
the variable 'output' is only assigned to a value inequal to NUL,
after all gotos to the corrupt label.
Therefore we can conclude the two removed lines are actually dead code.
Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
---
builtin/mailsplit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c
index 06296d4..b499014 100644
--- a/builtin/mailsplit.c
+++ b/builtin/mailsplit.c
@@ -93,8 +93,6 @@ static int split_one(FILE *mbox, const char *name, int allow_bare)
return status;
corrupt:
- if (output)
- fclose(output);
unlink(name);
fprintf(stderr, "corrupt mailbox\n");
exit(1);
--
2.1.0.rc2
next reply other threads:[~2014-08-11 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 21:11 Stefan Beller [this message]
2014-08-12 16:38 ` [PATCH] mailsplit.c: remove dead code René Scharfe
2014-08-12 21:21 ` Stefan Beller
2014-08-12 21:37 ` Matthieu Moy
2014-08-12 21:38 ` Junio C Hamano
2014-08-12 21:50 ` Junio C Hamano
2014-08-12 21:56 ` Matthieu Moy
2014-08-12 22:58 ` Jonathan Nieder
2014-08-17 8:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407791481-17410-1-git-send-email-stefanbeller@gmail.com \
--to=stefanbeller@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).