From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v3 10/21] send-pack: rename "new_refs" to "need_pack_data"
Date: Thu, 4 Sep 2014 13:04:46 -0700 [thread overview]
Message-ID: <1409861097-19151-11-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1409861097-19151-1-git-send-email-gitster@pobox.com>
The variable counts how many non-deleting command is being sent, but
is only checked with 0-ness to decide if we need to send the pack
data.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
send-pack.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/send-pack.c b/send-pack.c
index c1c64ee..590eb0a 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -220,7 +220,7 @@ int send_pack(struct send_pack_args *args,
struct strbuf req_buf = STRBUF_INIT;
struct strbuf cap_buf = STRBUF_INIT;
struct ref *ref;
- int new_refs;
+ int need_pack_data = 0;
int allow_deleting_refs = 0;
int status_report = 0;
int use_sideband = 0;
@@ -276,13 +276,12 @@ int send_pack(struct send_pack_args *args,
/*
* Finally, tell the other end!
*/
- new_refs = 0;
for (ref = remote_refs; ref; ref = ref->next) {
if (!ref_update_to_be_sent(ref, args))
continue;
if (!ref->deletion)
- new_refs++;
+ need_pack_data = 1;
if (args->dry_run) {
ref->status = REF_STATUS_OK;
@@ -327,7 +326,7 @@ int send_pack(struct send_pack_args *args,
in = demux.out;
}
- if (new_refs && cmds_sent) {
+ if (need_pack_data && cmds_sent) {
if (pack_objects(out, remote_refs, extra_have, args) < 0) {
for (ref = remote_refs; ref; ref = ref->next)
ref->status = REF_STATUS_NONE;
--
2.1.0-399-g1364b4d
next prev parent reply other threads:[~2014-09-04 20:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 20:04 [PATCH v3 00/21] Signed push Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 01/21] receive-pack: do not overallocate command structure Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 02/21] receive-pack: parse feature request a bit earlier Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 03/21] receive-pack: do not reuse old_sha1[] for other things Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 04/21] receive-pack: factor out queueing of command Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 05/21] send-pack: move REF_STATUS_REJECT_NODELETE logic a bit higher Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 06/21] send-pack: refactor decision to send update per ref Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 07/21] send-pack: always send capabilities Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 08/21] send-pack: factor out capability string generation Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 09/21] receive-pack: " Junio C Hamano
2014-09-04 20:04 ` Junio C Hamano [this message]
2014-09-04 20:04 ` [PATCH v3 11/21] send-pack: refactor inspecting and resetting status and sending commands Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 12/21] send-pack: clarify that cmds_sent is a boolean Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 13/21] gpg-interface: move parse_gpg_output() to where it should be Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 14/21] gpg-interface: move parse_signature() " Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 15/21] pack-protocol doc: typofix for PKT-LINE Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 16/21] push: the beginning of "git push --signed" Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 17/21] receive-pack: GPG-validate push certificates Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 18/21] send-pack: send feature request on push-cert packet Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 19/21] signed push: remove duplicated protocol info Junio C Hamano
2014-09-04 20:04 ` [PATCH v3 20/21] signed push: add "pushee" header to push certificate Junio C Hamano
2014-09-04 21:13 ` Shawn Pearce
2014-09-04 20:04 ` [PATCH v3 21/21] signed push: fortify against replay attacks Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409861097-19151-11-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).