From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Fabian Ruch <bafain@gmail.com>
Subject: [PATCH v2 1/2] t1503: test rev-parse --verify --quiet with deleted reflogs
Date: Sun, 14 Sep 2014 12:03:01 -0700 [thread overview]
Message-ID: <1410721382-97751-1-git-send-email-davvid@gmail.com> (raw)
Ensure that rev-parse --verify --quiet is silent when asked
about deleted reflog entries.
Helped-by: Fabian Ruch <bafain@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Changes since last time:
Use "git branch test" instead of low-level plumbing commands.
Capture both stdout and stderr in the test.
t/t1503-rev-parse-verify.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh
index 813cc1b..ab9878d 100755
--- a/t/t1503-rev-parse-verify.sh
+++ b/t/t1503-rev-parse-verify.sh
@@ -83,6 +83,13 @@ test_expect_success 'fails silently when using -q' '
test -z "$(cat error)"
'
+test_expect_success 'fails silently when using -q with deleted reflogs' '
+ git branch test &&
+ git reflog delete --updateref --rewrite test@{0} &&
+ test_must_fail git rev-parse -q --verify test@{0} >error 2>&1 &&
+ test -z "$(cat error)"
+'
+
test_expect_success 'no stdout output on error' '
test -z "$(git rev-parse --verify)" &&
test -z "$(git rev-parse --verify foo)" &&
--
2.1.0.30.g05c535b.dirty
next reply other threads:[~2014-09-14 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 19:03 David Aguilar [this message]
2014-09-14 19:03 ` [PATCH v2 2/2] t1503: use test_must_be_empty David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410721382-97751-1-git-send-email-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=bafain@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).