git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jeff King <peff@peff.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michal Sojka <sojka@merica.cz>,
	linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	Bryan Wu <cooloney@gmail.com>, Felipe Balbi <balbi@ti.com>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	linux-kernel@vger.kernel.org, michal.vokac@comap.cz,
	git <git@vger.kernel.org>
Subject: Re: project wide: git config entry for [diff] renames=true
Date: Thu, 25 Sep 2014 11:06:31 -0700	[thread overview]
Message-ID: <1411668391.3460.2.camel@joe-AO725> (raw)
In-Reply-To: <20140925180005.GA11755@peff.net>

On Thu, 2014-09-25 at 14:00 -0400, Jeff King wrote:
> On Thu, Sep 25, 2014 at 08:48:31AM -0700, Joe Perches wrote:
> 
> > On Thu, 2014-09-25 at 17:03 +0200, Greg Kroah-Hartman wrote:
> > 
> > > In the future, please generate a git "move" diff, which makes it easier
> > > to review, and prove that nothing really changed.  It also helps if the
> > > file is a bit different from what you diffed against, which in my case,
> > > was true.
> > 
> > Maybe it'd be possible to add 
> > 
> > [diff]
> > 	renames = true
> > 
> > to the .git/config file.
> > 
> > but I don't find a mechanism to add anything to the
> > .git/config and have it be pulled.
> 
> There is no such mechanism within git. We've resisted adding one because
> of the danger of something like:
> 
>   [diff]
>     external = rm -rf /
> 
> diff.renames is probably safe, but any config-sharing mechanism would
> have to deal with either whitelisting, or providing some mechanism for
> the puller to review changes before blindly following them.

Another mechanism might be to add a repository
top level .gitconfig and add whatever to that.

  reply	other threads:[~2014-09-25 18:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.44L0.1409241106100.1580-100000@iolanthe.rowland.org>
     [not found] ` <1411591401-5874-1-git-send-email-sojka@merica.cz>
     [not found]   ` <1411591401-5874-4-git-send-email-sojka@merica.cz>
     [not found]     ` <20140925150353.GA15325@kroah.com>
2014-09-25 15:48       ` project wide: git config entry for [diff] renames=true Joe Perches
2014-09-25 18:00         ` Jeff King
2014-09-25 18:06           ` Joe Perches [this message]
2014-09-25 18:43             ` Junio C Hamano
     [not found]           ` <20140925180005.GA11755-AdEPDUrAXsQ@public.gmane.org>
2014-09-25 18:53             ` Junio C Hamano
2014-09-25 18:55               ` Junio C Hamano
2014-10-03  1:37               ` [RFC/PATCH 0/2] Introduce safe-include config feature Rasmus Villemoes
2014-10-03  1:37                 ` [RFC/PATCH 1/2] config: Add safe-include directive Rasmus Villemoes
2014-10-03  5:27                   ` Junio C Hamano
2014-10-03  5:34                     ` Junio C Hamano
2014-10-03 18:52                     ` Junio C Hamano
2014-10-06  9:28                     ` Rasmus Villemoes
2014-10-06 17:58                       ` Junio C Hamano
2014-10-03  1:37                 ` [RFC/PATCH 2/2] config: Add test of safe-include feature Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411668391.3460.2.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=balbi@ti.com \
    --cc=cooloney@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.vokac@comap.cz \
    --cc=peff@peff.net \
    --cc=sojka@merica.cz \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).