git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: gitster@pobox.com
Cc: git@vger.kernel.org, mackyle@gmail.com, jhf@trifork.com,
	Eric Sunshine <sunshine@sunshineco.com>,
	Johan Herland <johan@herland.net>
Subject: [PATCHv3 0/5] Handling empty notes
Date: Fri,  7 Nov 2014 10:19:16 +0100	[thread overview]
Message-ID: <1415351961-31567-1-git-send-email-johan@herland.net> (raw)

Changes v1 -> v2:
 - Incorporate Eric's feedback
 - Factor out an initial fix, needed before adding the tests

Changes v2 -> v3:
 - Incorporate Junio's feedback
 - Move tests from t3312 to t3301
 - Refactor the display of empty notes (the part concerning
   git-log) into a separate follow-up patch (#4)
 - Add a final (optional) patch with some whitespace and other
   cleanups in t3301. Feel free to drop this if it's too much
   churn.


Have fun! :)

...Johan

Johan Herland (5):
  builtin/notes: Fix premature failure when trying to add the empty blob
  t3301: Verify that 'git notes' removes empty notes by default
  builtin/notes: Add --allow-empty, to allow storing empty notes
  notes: Empty notes should be shown by 'git log'
  t3301: Use write_script(), nitpick whitespace

 Documentation/git-notes.txt |  12 +-
 builtin/notes.c             |  25 ++--
 notes.c                     |   3 +-
 t/t3301-notes.sh            | 301 +++++++++++++++++++++++++-------------------
 4 files changed, 197 insertions(+), 144 deletions(-)

-- 
2.0.0.rc4.501.gdaf83ca

             reply	other threads:[~2014-11-07  9:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  9:19 Johan Herland [this message]
2014-11-07  9:19 ` [PATCHv3 1/5] builtin/notes: Fix premature failure when trying to add the empty blob Johan Herland
2014-11-07  9:19 ` [PATCHv3 2/5] t3301: Verify that 'git notes' removes empty notes by default Johan Herland
2014-11-07 17:48   ` Junio C Hamano
2014-11-07  9:19 ` [PATCHv3 3/5] builtin/notes: Add --allow-empty, to allow storing empty notes Johan Herland
2014-11-07 18:04   ` Junio C Hamano
2014-11-09 12:31     ` Johan Herland
2014-11-10 20:18       ` Junio C Hamano
2014-11-07  9:19 ` [PATCHv3 4/5] notes: Empty notes should be shown by 'git log' Johan Herland
2014-11-07 18:51   ` Junio C Hamano
2014-11-07  9:19 ` [PATCHv3 5/5] t3301: Use write_script(), nitpick whitespace Johan Herland
2014-11-07 18:55   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415351961-31567-1-git-send-email-johan@herland.net \
    --to=johan@herland.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jhf@trifork.com \
    --cc=mackyle@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).