git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: gitster@pobox.com
Cc: git@vger.kernel.org, mackyle@gmail.com, jhf@trifork.com,
	sunshine@sunshineco.com, peff@peff.net, blume.mike@gmail.com,
	Johan Herland <johan@herland.net>
Subject: [PATCHv5 0/9] Handling empty notes
Date: Wed, 12 Nov 2014 01:40:07 +0100	[thread overview]
Message-ID: <1415752816-22782-1-git-send-email-johan@herland.net> (raw)

Changes v4 -> v5:

 - Patch #5: Reorder code to ease readability and fix issue with
   checking d.given after free_note_data(&d), noticed by Junio.

 - Patch #9: Fix typo in commit message, noticed by Junio.

 - Patch #9: Rename "output" files to "actual", suggested by Eric.

 - Patch #9: Use test_line_count instead of wc -l, which behaves
   differently on Macs. noticed by Michael, diagnosed by Eric, and
   fix suggested by Peff.

 - Patch #9: Use -r option to ls-tree when counting entries in notes,
   tree as this also works for trees with fanout level > 0. Noticed
   by Peff.


Have fun! :)

...Johan


Johan Herland (9):
  builtin/notes: Fix premature failure when trying to add the empty blob
  t3301: Verify that 'git notes' removes empty notes by default
  builtin/notes: Improve naming
  builtin/notes: Refactor note file path into struct note_data
  builtin/notes: Simplify early exit code in add()
  builtin/notes: Split create_note() to clarify add vs. remove logic
  builtin/notes: Add --allow-empty, to allow storing empty notes
  notes: Empty notes should be shown by 'git log'
  t3301: Modernize

 Documentation/git-notes.txt |   12 +-
 builtin/notes.c             |  258 +++++----
 notes.c                     |    3 +-
 t/t3301-notes.sh            | 1341 +++++++++++++++++++++----------------------
 4 files changed, 789 insertions(+), 825 deletions(-)

-- 
2.0.0.rc4.501.gdaf83ca

             reply	other threads:[~2014-11-12  0:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12  0:40 Johan Herland [this message]
2014-11-12  0:40 ` [PATCHv5 1/9] builtin/notes: Fix premature failure when trying to add the empty blob Johan Herland
2014-11-12  0:40 ` [PATCHv5 2/9] t3301: Verify that 'git notes' removes empty notes by default Johan Herland
2014-11-12  0:40 ` [PATCHv5 3/9] builtin/notes: Improve naming Johan Herland
2014-11-12  0:40 ` [PATCHv5 4/9] builtin/notes: Refactor note file path into struct note_data Johan Herland
2014-11-12  0:40 ` [PATCHv5 5/9] builtin/notes: Simplify early exit code in add() Johan Herland
2014-11-12  0:40 ` [PATCHv5 6/9] builtin/notes: Split create_note() to clarify add vs. remove logic Johan Herland
2014-11-12  0:40 ` [PATCHv5 7/9] builtin/notes: Add --allow-empty, to allow storing empty notes Johan Herland
2014-11-12  0:40 ` [PATCHv5 8/9] notes: Empty notes should be shown by 'git log' Johan Herland
2014-11-12  0:40 ` [PATCHv5 9/9] t3301: Modernize Johan Herland
2014-11-12  1:57   ` Eric Sunshine
2014-11-12  9:08     ` Johan Herland
2014-11-12 21:18       ` Junio C Hamano
2014-11-12 23:43         ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415752816-22782-1-git-send-email-johan@herland.net \
    --to=johan@herland.net \
    --cc=blume.mike@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jhf@trifork.com \
    --cc=mackyle@gmail.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).