From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Wong <normalperson@yhbt.net>,
Karsten Blees <karsten.blees@gmail.com>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH 0/2] Don't make $GIT_DIR executable
Date: Sat, 15 Nov 2014 08:26:17 +0100 [thread overview]
Message-ID: <1416036379-4994-1-git-send-email-mhagger@alum.mit.edu> (raw)
Starting with v2.1.0, "git init" creates $GIT_DIR/config with its u+x
bit set. These two patches are "belt and suspenders"--either one would
fix the bug, but IMO it makes sense to apply both of them. Plus, the
second patch will help repair repositories that were created while
this bug was in the wild.
I think these patches should go into "maint". They apply cleanly
there. When merging forward to master, there are two conflicts in
config.c which can be resolved by
s/lock->filename/lock->filename.buf/
in two places.
Michael Haggerty (2):
create_default_files(): don't set u+x bit on $GIT_DIR/config
config: clear the executable bits (if any) on $GIT_DIR/config
builtin/init-db.c | 1 +
config.c | 12 ++++++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
--
2.1.1
next reply other threads:[~2014-11-15 7:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 7:26 Michael Haggerty [this message]
2014-11-15 7:26 ` [PATCH 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config Michael Haggerty
2014-11-15 12:06 ` Torsten Bögershausen
2014-11-16 5:23 ` Michael Haggerty
2014-11-15 7:26 ` [PATCH 2/2] config: clear the executable bits (if any) " Michael Haggerty
2014-11-15 7:32 ` Stefan Beller
2014-11-15 7:42 ` Michael Haggerty
2014-11-16 18:49 ` Junio C Hamano
2014-11-17 8:26 ` Michael Haggerty
2014-11-17 15:33 ` Junio C Hamano
2014-11-17 16:00 ` Michael Haggerty
2014-11-15 7:50 ` [PATCH 0/2] Don't make $GIT_DIR executable Eric Wong
2014-11-16 6:14 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416036379-4994-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).